Skip to content

chore: Pin rust toolchain to latest stable to prevent random CI failures #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rbro112 wants to merge 1 commit into from
Closed

chore: Pin rust toolchain to latest stable to prevent random CI failures #2685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2

- name: Install Rust Toolchain
run: rustup toolchain install stable --profile minimal --component clippy --component rustfmt --no-self-update
# Pin to specific version to avoid clippy lint changes in new releases
run: rustup toolchain install 1.89.0 --profile minimal --component clippy --component rustfmt --no-self-update
Copy link
Copy Markdown

@cursor cursor bot Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Rust Workflow Fails Due to Incorrect Toolchain

The lint.yml workflow installs Rust toolchain 1.89.0 but doesn't set it as the default. Consequently, subsequent rustup target add and cargo commands (e.g., fmt, clippy) may use a different toolchain, defeating the purpose of pinning the version to prevent CI failures. Fix by setting 1.89.0 as default (rustup default 1.89.0) or explicitly specifying it for each command (e.g., cargo +1.89.0).

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Member

@szokeasaurusrex szokeasaurusrex Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid. Just because we install a specific version does not pin that version for the cargo commands we run here. #2687 should pin for all cargo commands


- name: Add Target
run: rustup target add ${{ matrix.target }}
Expand Down