ci(release): Use container in workflow instead of build-in-docker.sh#2727
Merged
szokeasaurusrex merged 1 commit intomasterfrom Sep 9, 2025
Conversation
This eases maintainability, as the workflow is direcltly defined in `build.yml`. This will also allow us to add caching of dependencies more easily, and make the workflow for Linux more closely match the workflow for macOS and Windows.
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lcian
approved these changes
Sep 9, 2025
Member
lcian
left a comment
lcian
left a comment
There was a problem hiding this comment.
Change looks good to me! Let's maybe run this action after merging to check it works as expected.
Member
Author
|
I thought I tested it already @lcian but looks like I did not. Will push to |
szokeasaurusrex
deleted the
09-03-ci_release_use_container_in_workflow_instead_of_build-in-docker.sh_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eases maintainability, as the workflow is direcltly defined in
build.yml. This will also allow us to add caching of dependencies more easily, and make the workflow for Linux more closely match the workflow for macOS and Windows.We also remove the smoke test, which never triggered anyways, as it was relying on Travis environment variables.