Skip to content

test action with PR trigger and older Rust version #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szokeasaurusrex wants to merge 1 commit into from
Closed

test action with PR trigger and older Rust version #2757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/rust-toolchain-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
schedule:
# Run weekly on Mondays at 00:00 UTC
- cron: '0 0 * * 1'
pull_request:

jobs:
check-and-update:
Expand Down Expand Up @@ -106,7 +107,7 @@ jobs:
repo: context.repo.repo,
title: commitTitle,
head: branchName,
base: '${{ github.ref_name }}',
base: '${{ github.head_ref }}',
Copy link
Copy Markdown

@cursor cursor bot Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: PR Branch Reference Issue

The PR base branch changed from github.ref_name to github.head_ref. This breaks scheduled runs, as github.head_ref is empty, causing PR creation to fail. For PR-triggered runs, it incorrectly targets the triggering PR's source branch instead of the intended base, like github.ref_name provided.

Fix in Cursor Fix in Web

body: `Update Rust toolchain to ${newVersion} (${fullVersion}).

**Changes:**
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[toolchain]
# We pin the minor version to prevent new Clippy lints from breaking CI.
# But, we still want to pick up new patch versions.
channel = "1.89"
channel = "1.88"
Loading