chore(launchpad): Remove org argument from build upload command#2796
chore(launchpad): Remove org argument from build upload command#2796NicoHinderling wants to merge 1 commit intomasterfrom
Conversation
| "The path to the build to upload. Supported files include Apk, and Aab."; | ||
| command | ||
| .about("[EXPERIMENTAL] Upload builds to a project.") | ||
| .org_arg() | ||
| .project_arg(false) | ||
| .arg( | ||
| Arg::new("paths") |
There was a problem hiding this comment.
Potential bug: The build upload command fails with an error message that suggests using the --org flag, which the command no longer accepts, creating an unresolvable state for some users.
-
Description: The
build uploadcommand no longer accepts the--orgargument because the.org_arg()call was removed. However, if an organization cannot be determined from an auth token, environment variable, or config file, the underlyingget_orgfunction fails with an error message suggesting the userprovide with --org. This creates a dead-end for users, particularly those with user-level auth tokens or legacy API keys, as the command fails and instructs them to use a command-line flag that is no longer supported for this specific command, preventing them from proceeding. -
Suggested fix: Re-add the
.org_arg()call to thebuild uploadcommand definition insrc/commands/build/upload.rs. This will restore the ability for users to specify the organization via the--orgflag, making the error message's suggestion valid again and resolving the functional regression.
severity: 0.65, confidence: 0.95
Did we get this right? 👍 / 👎 to inform future reviews.
7a96fa7 to
8cdb705
Compare
8cdb705 to
599667f
Compare
|
actually we need the org id to create the URL path to even start the upload. since the chunking config endpoint needs it too, no point in changing the endpoint path for assemble to not include the org id. better to just add logic in the endpoint verifying that the project and org are valid |
There was a problem hiding this comment.
Bug: API URL Construction Fails Without `org` Argument
The org argument was removed from the build upload command, but the organization ID is still required to construct API URLs for the upload process and chunking configuration. This will cause the upload command to fail at runtime.
src/commands/build/upload.rs#L39-L40
sentry-cli/src/commands/build/upload.rs
Lines 39 to 40 in 599667f
There's no point in having the org specified because the project and auth token should be able to infer the organization