Skip to content

chore(launchpad): Remove org argument from build upload command#2796

Closed
NicoHinderling wants to merge 1 commit intomasterfrom
remove-org-arg-from-upload
Closed

chore(launchpad): Remove org argument from build upload command#2796
NicoHinderling wants to merge 1 commit intomasterfrom
remove-org-arg-from-upload

Conversation

@NicoHinderling
Copy link
Copy Markdown
Contributor

There's no point in having the org specified because the project and auth token should be able to infer the organization

Comment on lines 38 to 43
"The path to the build to upload. Supported files include Apk, and Aab.";
command
.about("[EXPERIMENTAL] Upload builds to a project.")
.org_arg()
.project_arg(false)
.arg(
Arg::new("paths")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The build upload command fails with an error message that suggests using the --org flag, which the command no longer accepts, creating an unresolvable state for some users.
  • Description: The build upload command no longer accepts the --org argument because the .org_arg() call was removed. However, if an organization cannot be determined from an auth token, environment variable, or config file, the underlying get_org function fails with an error message suggesting the user provide with --org. This creates a dead-end for users, particularly those with user-level auth tokens or legacy API keys, as the command fails and instructs them to use a command-line flag that is no longer supported for this specific command, preventing them from proceeding.

  • Suggested fix: Re-add the .org_arg() call to the build upload command definition in src/commands/build/upload.rs. This will restore the ability for users to specify the organization via the --org flag, making the error message's suggestion valid again and resolving the functional regression.
    severity: 0.65, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

@NicoHinderling NicoHinderling force-pushed the remove-org-arg-from-upload branch from 7a96fa7 to 8cdb705 Compare September 24, 2025 04:56
@NicoHinderling NicoHinderling force-pushed the remove-org-arg-from-upload branch from 8cdb705 to 599667f Compare September 24, 2025 05:03
@NicoHinderling
Copy link
Copy Markdown
Contributor Author

actually we need the org id to create the URL path to even start the upload. since the chunking config endpoint needs it too, no point in changing the endpoint path for assemble to not include the org id. better to just add logic in the endpoint verifying that the project and org are valid

@NicoHinderling NicoHinderling requested a review from a team as a code owner September 24, 2025 17:40
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API URL Construction Fails Without `org` Argument

The org argument was removed from the build upload command, but the organization ID is still required to construct API URLs for the upload process and chunking configuration. This will cause the upload command to fail at runtime.

src/commands/build/upload.rs#L39-L40

command
.about("[EXPERIMENTAL] Upload builds to a project.")

Fix in Cursor Fix in Web


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants