Skip to content

chore(launchpad): Remove org argument from build upload command #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NicoHinderling wants to merge 1 commit into from
Closed

chore(launchpad): Remove org argument from build upload command #2796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/commands/build/upload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ pub fn make_command(command: Command) -> Command {
"The path to the build to upload. Supported files include Apk, and Aab.";
command
.about("[EXPERIMENTAL] Upload builds to a project.")
.org_arg()
.project_arg(false)
.arg(
Arg::new("paths")
Comment on lines 38 to 43
Copy link
Copy Markdown

@seer-by-sentry seer-by-sentry bot Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The build upload command fails with an error message that suggests using the --org flag, which the command no longer accepts, creating an unresolvable state for some users.

  • Description: The build upload command no longer accepts the --org argument because the .org_arg() call was removed. However, if an organization cannot be determined from an auth token, environment variable, or config file, the underlying get_org function fails with an error message suggesting the user provide with --org. This creates a dead-end for users, particularly those with user-level auth tokens or legacy API keys, as the command fails and instructs them to use a command-line flag that is no longer supported for this specific command, preventing them from proceeding.

  • Suggested fix: Re-add the .org_arg() call to the build upload command definition in src/commands/build/upload.rs. This will restore the ability for users to specify the organization via the --org flag, making the error message's suggestion valid again and resolving the functional regression.
    severity: 0.65, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

Expand Down
2 changes: 0 additions & 2 deletions tests/integration/_cases/build/build-upload-help-macos.trycmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ Arguments:
<PATH>... The path to the build to upload. Supported files include Apk, Aab, XCArchive, and IPA.

Options:
-o, --org <ORG>
The organization ID or slug.
--header <KEY:VALUE>
Custom headers that should be attached to all requests
in key:value format.
Expand Down
2 changes: 0 additions & 2 deletions tests/integration/_cases/build/build-upload-help-not-macos.trycmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ Arguments:
<PATH>... The path to the build to upload. Supported files include Apk, and Aab.

Options:
-o, --org <ORG>
The organization ID or slug.
--header <KEY:VALUE>
Custom headers that should be attached to all requests
in key:value format.
Expand Down
Loading