Skip to content

test: Add #[serial] to GitHub env var tests #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runningcode merged 1 commit into from
Oct 9, 2025
Merged

test: Add #[serial] to GitHub env var tests #2832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/utils/vcs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,7 @@ mod tests {
}

#[test]
#[serial(github_env)]
fn test_get_github_pr_number() {
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
std::env::set_var("GITHUB_REF", "refs/pull/123/merge");
Expand All @@ -1534,6 +1535,7 @@ mod tests {
}

#[test]
#[serial(github_env)]
fn test_get_github_base_ref() {
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
std::env::set_var("GITHUB_BASE_REF", "main");
Expand Down Expand Up @@ -1658,7 +1660,7 @@ mod tests {
}

#[test]
#[serial(github_event_path)]
#[serial(github_env)]
Copy link
Copy Markdown

@cursor cursor bot Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test Grouping Issue Causes Interference

Changing the #[serial] attribute from github_event_path to github_env groups tests manipulating GITHUB_EVENT_PATH with tests that use other GITHUB_* environment variables. This removes the logical separation for tests relying on GITHUB_EVENT_PATH, potentially causing interference.

Additional Locations (1)

Fix in Cursor Fix in Web

fn test_find_head_with_github_event_path() {
use std::fs;

Expand Down Expand Up @@ -1738,7 +1740,7 @@ mod tests {
}

#[test]
#[serial(github_event_path)]
#[serial(github_env)]
fn test_find_base_sha() {
use std::fs;

Expand Down