chore(preprod): Save images as original file format to ParsedAssets#2859
Merged
NicoHinderling merged 2 commits intomasterfrom Oct 21, 2025
Merged
chore(preprod): Save images as original file format to ParsedAssets#2859NicoHinderling merged 2 commits intomasterfrom
NicoHinderling merged 2 commits intomasterfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
NicoHinderling
force-pushed
the
nico-wip-original-file-protecting
branch
from
aed7bd9 to
1a589db
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
trevor-e
approved these changes
Oct 20, 2025
| case "bmp": | ||
| return UTType.bmp.identifier | ||
| default: | ||
| return UTType.png.identifier |
Member
There was a problem hiding this comment.
Can this be more defensive? I'd like it to only handle types that we know, otherwise return nil as an optional.
| images[imageId] = unslicedImage | ||
|
|
||
| let fileExtension = (renditionTypeName as NSString).pathExtension.lowercased() | ||
| let originalFormat = fileExtension.isEmpty ? "png" : fileExtension |
Member
There was a problem hiding this comment.
Same, perhaps skip over files that don't have an extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParsedAssets currently contains all the images we extracted but they are all saved as PNGs. We want to keep them in their original format to make sure that our image insights are as accurate possible, and having them converted to PNG can disrupt this
Appears to work and be processed by launchpad correctly from local testing