Skip to content

chore(preprod): Improve error messaging for zip normalizing step in case of duplicate filename case #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicoHinderling merged 2 commits into from
Oct 23, 2025
Merged

chore(preprod): Improve error messaging for zip normalizing step in case of duplicate filename case #2864

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d1edd3
chore(preprod): Improve error messaging for zip normalizing step in c…
NicoHinderling Oct 22, 2025
b18718f
fix(build): Use proper string slice references in zip operations
runningcode Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/utils/build/normalize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use std::os::unix::fs::PermissionsExt as _;
use std::path::{Path, PathBuf};

use crate::utils::fs::TempFile;
use anyhow::Result;
use anyhow::{Context as _, Result};
use itertools::Itertools as _;
use log::debug;
use symbolic::common::ByteView;
Expand Down Expand Up @@ -61,10 +61,12 @@ fn add_entries_to_zip(
let target_str = target.to_string_lossy();

// Create a symlink entry in the zip
zip.add_symlink(zip_path, &target_str, options)?;
zip.add_symlink(&zip_path, &target_str, options)
.with_context(|| format!("Failed to add symlink '{}' to zip archive", zip_path))?;
Comment thread
runningcode marked this conversation as resolved.
Outdated
} else {
// Handle regular files
zip.start_file(zip_path, options)?;
zip.start_file(&zip_path, options)
.with_context(|| format!("Failed to add file '{}' to zip archive", zip_path))?;
let file_byteview = ByteView::open(&entry_path)?;
zip.write_all(file_byteview.as_slice())?;
}
Expand Down
Loading