Skip to content

ref(vcs): Rename find_head -> find_head_sha#2887

Merged
chromy merged 1 commit intomasterfrom
chromy/2025-09-29-rename-find-head
Oct 29, 2025
Merged

ref(vcs): Rename find_head -> find_head_sha#2887
chromy merged 1 commit intomasterfrom
chromy/2025-09-29-rename-find-head

Conversation

@chromy
Copy link
Copy Markdown
Contributor

@chromy chromy commented Oct 29, 2025

This makes find_head_sha match its counterpart find_base_sha.

@chromy chromy requested review from a team and szokeasaurusrex as code owners October 29, 2025 11:24
@chromy chromy force-pushed the chromy/2025-09-29-rename-find-head branch from 92c83f4 to b99465c Compare October 29, 2025 11:26
@chromy chromy changed the title ref(vcs): Rename find_head -> find_head_sha to match find_base_sha ref(vcs): Rename find_head -> find_head_sha Oct 29, 2025
Copy link
Copy Markdown
Contributor

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. This function was previously named find_head because it was used for the releases feature. Now that we have one for the sha and one for the ref this makes sense.

@chromy chromy merged commit 0a539c6 into master Oct 29, 2025
28 checks passed
@chromy chromy deleted the chromy/2025-09-29-rename-find-head branch October 29, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants