diff --git a/Cargo.toml b/Cargo.toml index f0681459b5..be3de67f91 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -99,8 +99,8 @@ with_crash_reporting = [] allow-attributes = "warn" dbg-macro = "warn" elidable-lifetime-names = "warn" +implicit-clone = "warn" str-to-string = "warn" -string-to-string = "warn" tests-outside-test-module = "warn" unnecessary-wraps = "warn" uninlined-format-args = "warn" diff --git a/src/commands/debug_files/bundle_jvm.rs b/src/commands/debug_files/bundle_jvm.rs index 15236dc8b5..884c944e35 100644 --- a/src/commands/debug_files/bundle_jvm.rs +++ b/src/commands/debug_files/bundle_jvm.rs @@ -75,7 +75,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> { ))?; } - let sources = ReleaseFileSearch::new(path.to_path_buf()).collect_files()?; + let sources = ReleaseFileSearch::new(path.clone()).collect_files()?; let files = sources.iter().map(|source| { let local_path = source.path.strip_prefix(&source.base_path).unwrap(); let local_path_jvm_ext = local_path.with_extension("jvm"); diff --git a/src/commands/debug_files/find.rs b/src/commands/debug_files/find.rs index 52843dc856..4cd78c313b 100644 --- a/src/commands/debug_files/find.rs +++ b/src/commands/debug_files/find.rs @@ -324,7 +324,7 @@ where { ids.filter_map(|id| { if remaining.contains(&id) { - return Some((id.to_owned(), t)); + return Some((id, t)); } None }) diff --git a/src/commands/upload_proguard.rs b/src/commands/upload_proguard.rs index 239f381a6e..cdb2cb69c2 100644 --- a/src/commands/upload_proguard.rs +++ b/src/commands/upload_proguard.rs @@ -332,7 +332,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> { &org, &project, &AssociateProguard { - release_name: release_name.to_owned(), + release_name: release_name.clone(), proguard_uuid: uuid.to_string(), }, )?; diff --git a/src/utils/xcode.rs b/src/utils/xcode.rs index 2d50f60a4b..6c62ce5131 100644 --- a/src/utils/xcode.rs +++ b/src/utils/xcode.rs @@ -93,7 +93,7 @@ fn get_xcode_project_info(path: &Path) -> Result> { for entry in (fs::read_dir(path)?).flatten() { if let Some(filename) = entry.file_name().to_str() { if filename.ends_with(".xcodeproj") { - projects.push(entry.path().to_path_buf()); + projects.push(entry.path().clone()); } } }