fix(build): Namespace snapshot object keys by org and project#3166
Closed
runningcode wants to merge 1 commit intomasterfrom
Closed
fix(build): Namespace snapshot object keys by org and project#3166runningcode wants to merge 1 commit intomasterfrom
runningcode wants to merge 1 commit intomasterfrom
Conversation
Previously, snapshot images were stored using only their SHA256 hash as
the object key. This could cause collisions or incorrect sharing of
objects across organizations and projects with identical file contents.
Now keys are scoped as `{org_id}/{project_id}/{hash}` to ensure proper
isolation in the object store.
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Namespace snapshot object keys by org and project ([#3166](https://github.com/getsentry/sentry-cli/pull/3166))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Snapshot images are now stored using
{org_id}/{project_id}/{hash}as the object key instead of just{hash}.Why
Using only the SHA256 hash as the object key could cause collisions or unintended sharing of objects across organizations and projects that happen to upload identical files.