feat(snapshots): Use retention endpoint for objectstore expiration#3180
Closed
NicoHinderling wants to merge 1 commit intomasterfrom
Closed
feat(snapshots): Use retention endpoint for objectstore expiration#3180NicoHinderling wants to merge 1 commit intomasterfrom
NicoHinderling wants to merge 1 commit intomasterfrom
Conversation
…licy Fetch the snapshot retention value from the organization's preprod retention endpoint instead of using the expiration policy from the upload-options response. This allows the retention period to be configured per-organization via the backend. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Use retention endpoint for objectstore expiration ([#3180](https://github.com/getsentry/sentry-cli/pull/3180))If none of the above apply, you can opt out of this check by adding |
NicoHinderling
added
the
skip-changelog
Contributor
Author
|
synced offline, forgot we have an endpoint dedicated for this case specifically for CLI already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: getsentry/sentry#109842
Fetch the snapshot retention value (in days) from
GET /organizations/{org}/preprod/retention/and use it to construct aTimeToLiveexpiration policy for objectstore uploads, instead of using theexpiration_policystring from the upload-options response.This allows snapshot retention to be configured per-organization via the
backend rather than being hardcoded in the objectstore upload options.
Refs EME-885