build(deps): bump @tootallnate/once and jest#3188
Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
Closed
build(deps): bump @tootallnate/once and jest#3188dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Removes [@tootallnate/once](https://github.com/TooTallNate/once). It's no longer used after updating ancestor dependency [jest](https://github.com/jestjs/jest/tree/HEAD/packages/jest). These dependencies need to be updated together. Removes `@tootallnate/once` Updates `jest` from 27.5.1 to 30.2.0 - [Release notes](https://github.com/jestjs/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/jestjs/jest/commits/v30.2.0/packages/jest) --- updated-dependencies: - dependency-name: "@tootallnate/once" dependency-version: dependency-type: indirect - dependency-name: jest dependency-version: 30.2.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "eslint": "^7.32.0", | ||
| "eslint-config-prettier": "^8.5.0", | ||
| "jest": "^27.5.1", | ||
| "jest": "^30.2.0", |
There was a problem hiding this comment.
Bug: The jest dependency is updated to a new major version, but ts-jest is not, causing an incompatibility that will break the test suite.
Severity: CRITICAL
Suggested Fix
Update the ts-jest dependency in package.json to a version that is compatible with the new major version of jest. For example, if jest is updated to version 29, ts-jest should also be updated to version 29.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L28
Potential issue: The pull request updates the `jest` dependency from `^27.5.1` to a new
major version but does not update the corresponding `ts-jest` dependency, which remains
at `^27.1.5`. The `ts-jest` library's major version is tightly coupled with Jest's major
version. `ts-jest` version 27 is only compatible with Jest 27 and will not work with a
newer major version of Jest. Since the project's Jest configuration uses `ts-jest` to
transform TypeScript files, running the test suite via `npm test` will cause a runtime
failure in the CI pipeline, blocking further development and deployments.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
|
closed in favor of #3191 |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes @tootallnate/once. It's no longer used after updating ancestor dependency jest. These dependencies need to be updated together.
Removes
@tootallnate/onceUpdates
jestfrom 27.5.1 to 30.2.0Release notes
Sourced from jest's releases.
... (truncated)
Changelog
Sourced from jest's changelog.
... (truncated)
Commits
855864ev30.2.0da9b532v30.1.3ebfa31cv30.1.2d347c0fv30.1.14d5f41dv30.1.022236cfv30.0.5f4296d2v30.0.4d4a6c94v30.0.3393acbfv30.0.25ce865bv30.0.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.