feat(snapshots): Authenticate with Objectstore#3258
Open
Conversation
Bump objectstore-client to 0.1.6 and use the dedicated auth token from ObjectstoreUploadOptions when available, instead of always reusing the Sentry auth token. The Sentry token is now passed as a Bearer authorization header via configure_reqwest for request verification. This resolves the TODO in the previous implementation and decouples objectstore authentication from Sentry authentication. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lcian
changed the title
Contributor
|
lcian
added
the
skip-changelog
The objectstore-client 0.1.6 upgrade changed send() to return a Future, so it needs to be awaited before calling error_for_failures(). Also add changelog entry for the PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Enable the serde feature on secrecy and use SecretString instead of plain String for the auth_token field in ObjectstoreUploadOptions. This prevents accidental logging of the token. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
objectstore-clientto 0.1.6 and use the dedicated auth token now returned byObjectstoreUploadOptions..tokenin the newest version of Objectstore client passes it in theX-Os-Authheader.The Sentry auth token is still passed through the standard
Authorizationheader for auth with Django.#skip-changelog