Fix test

Author: noahsmartin

Sources/SentryCrash/Recording/SentryCrashBinaryImageCache.c

@@ -212,18 +212,14 @@ sentrycrashbic_addDyldNode(void)
     }
 
     PublishedBinaryImage *entry = &g_images[idx];
-    if (!sentrycrashdl_getBinaryImageForHeader((const void *)header, "dyld", &entry->image, false)) {
+    if (!sentrycrashdl_getBinaryImageForHeader(
+            (const void *)header, "dyld", &entry->image, false)) {
         // Decrement because we couldn't add the image
         atomic_fetch_sub_explicit(&g_next_index, 1, memory_order_relaxed);
         return;
     }
 
-    sentrycrashbic_cacheChangeCallback callback
-        = atomic_load_explicit(&g_addedCallback, memory_order_acquire);
     atomic_store_explicit(&entry->ready, 1, memory_order_release);
-    if (callback != NULL) {
-        callback(&entry->image);
-    }
 }
 
 static void

Tests/SentryTests/SentryCrash/SentryCrashBinaryImageCacheTests.m

@@ -289,10 +289,10 @@ - (void)testSentryBinaryImageCacheIntegration
     // by calling start, SentryBinaryImageCache will register a callback with
     // `SentryCrashBinaryImageCache` that should be called for every image already cached.
     NSMutableArray<NSString *> *paths = [NSMutableArray new];
-    [imageCache.cache enumerateObjectsUsingBlock:^(SentryBinaryImageInfo * _Nonnull obj, NSUInteger __unused idx, BOOL * _Nonnull __unused stop) {
-        [paths addObject:obj.name];
-    }];
-    XCTAssertEqual(5, imageCache.cache.count, @"Cache should start with 5 images but contained %@", paths);
+    [imageCache.cache enumerateObjectsUsingBlock:^(SentryBinaryImageInfo *_Nonnull obj,
+        NSUInteger __unused idx, BOOL *_Nonnull __unused stop) { [paths addObject:obj.name]; }];
+    XCTAssertEqual(
+        5, imageCache.cache.count, @"Cache should start with 5 images but contained %@", paths);
 
     addBinaryImage([mach_headers_test_cache[5] pointerValue], 0);
     XCTAssertEqual(6, imageCache.cache.count);
@@ -311,10 +311,11 @@ - (void)assertBinaryImageCacheLength:(int)expected
     int counter = 0;
     sentrycrashbic_iterateOverImages(countNumberOfImagesInCache, &counter);
     NSMutableArray<NSString *> *paths = [NSMutableArray new];
-    [SentryDependencyContainer.sharedInstance.binaryImageCache.cache enumerateObjectsUsingBlock:^(SentryBinaryImageInfo * _Nonnull obj, NSUInteger __unused idx, BOOL * _Nonnull __unused stop) {
-        [paths addObject:obj.name];
-    }];
-    XCTAssertEqual(counter, expected, @"Cache should have %d images but contained %@", expected, paths);
+    [SentryDependencyContainer.sharedInstance.binaryImageCache.cache
+        enumerateObjectsUsingBlock:^(SentryBinaryImageInfo *_Nonnull obj, NSUInteger __unused idx,
+            BOOL *_Nonnull __unused stop) { [paths addObject:obj.name]; }];
+    XCTAssertEqual(
+        counter, expected, @"Cache should have %d images but contained %@", expected, paths);
 }
 
 - (void)assertCachedBinaryImages