review-feedback: Document usage of objc_getAssociatedState key

43jay · 43jay · commit a8d3bbbea9ee · 2026-04-23T16:28:37.000-04:00
#7588 (comment)
diff --git a/Sources/Sentry/SentryNetworkTracker.m b/Sources/Sentry/SentryNetworkTracker.m
@@ -573,7 +573,9 @@ - (SentryLevel)getBreadcrumbLevel:(NSURLSessionTask *)sessionTask
 }
 
 #if SENTRY_TARGET_REPLAY_SUPPORTED
-// Store extracted network details data for session replay.
+// Associated object key for attaching SentryReplayNetworkDetails to each NSURLSessionTask.
+// Safe: setAssociatedObject follows existing patterns in urlSessionTask:setState:
+// and getAssociatedObject is called from blocks that hold a strong reference to the task.
 static const void *SentryNetworkDetailsKey = &SentryNetworkDetailsKey;
 
 - (BOOL)isNetworkDetailCaptureEnabledFor:(NSString *)urlString options:(SentryOptions *)options

Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,9 @@ - (SentryLevel)getBreadcrumbLevel:(NSURLSessionTask *)sessionTask`
`573`	`573`	`}`
`574`	`574`
`575`	`575`	`#if SENTRY_TARGET_REPLAY_SUPPORTED`
`576`		`-// Store extracted network details data for session replay.`
	`576`	`+// Associated object key for attaching SentryReplayNetworkDetails to each NSURLSessionTask.`
	`577`	`+// Safe: setAssociatedObject follows existing patterns in urlSessionTask:setState:`
	`578`	`+// and getAssociatedObject is called from blocks that hold a strong reference to the task.`
`577`	`579`	`static const void *SentryNetworkDetailsKey = &SentryNetworkDetailsKey;`
`578`	`580`
`579`	`581`	`- (BOOL)isNetworkDetailCaptureEnabledFor:(NSString )urlString options:(SentryOptions )options`