ref: Migrate SentryBinaryImageCache to Swift

[itaybre]

RN are failing due to an import, but I fixed than on getsentry/sentry-react-native#5109

#skip-changelog

[linear]

COCOA-552 Convert SentryBinaryImageCache to Swift

[codecov]

Codecov Report

❌ Patch coverage is 92.71523% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.741%. Comparing base (1b008ee) to head (9d53080).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ces/Swift/Core/Helper/SentryBinaryImageCache.swift	95.419%	6 Missing ⚠️
...yCrash/Recording/SentryBinaryImageCacheCallbacks.m	72.222%	5 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #5995       +/-   ##
=============================================
+ Coverage   86.570%   86.741%   +0.171%     
=============================================
  Files          424       425        +1     
  Lines        36710     36747       +37     
  Branches     15747     17370     +1623     
=============================================
+ Hits         31780     31875       +95     
+ Misses        4888      4827       -61     
- Partials        42        45        +3     

Files with missing lines	Coverage Δ
Sources/Sentry/SentryCrashStackEntryMapper.m	100.000% <100.000%> (ø)
Sources/Sentry/SentryDebugImageProvider.m	89.051% <100.000%> (ø)
Sources/Sentry/SentryDependencyContainer.m	88.425% <ø> (ø)
Sources/Sentry/SentrySDKInternal.m	86.885% <ø> (ø)
Sources/Sentry/SentryUIViewControllerSwizzling.m	90.140% <ø> (ø)
Sources/Sentry/include/SentryCrashDynamicLinker.h	100.000% <ø> (ø)
...yCrash/Recording/SentryBinaryImageCacheCallbacks.m	72.222% <72.222%> (ø)
...ces/Swift/Core/Helper/SentryBinaryImageCache.swift	95.419% <95.419%> (ø)

... and 20 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b008ee...9d53080. Read the comment docs.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1218.91 ms	1244.63 ms	25.72 ms
Size	23.75 KiB	933.04 KiB	909.29 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
5aa3ce5	1222.78 ms	1245.39 ms	22.61 ms
d23a1b1	1218.94 ms	1239.53 ms	20.60 ms
2a6f451	1212.89 ms	1237.45 ms	24.56 ms
0529194	1237.23 ms	1254.67 ms	17.44 ms
2481950	1221.04 ms	1248.98 ms	27.94 ms
f92cfa9	1217.94 ms	1240.06 ms	22.12 ms
0b5fd21	1237.52 ms	1251.36 ms	13.84 ms
7eafbde	1212.16 ms	1243.64 ms	31.48 ms
c2982e7	1223.92 ms	1242.86 ms	18.94 ms
82f60cf	1218.65 ms	1238.52 ms	19.87 ms

App size

Revision	Plain	With Sentry	Diff
5aa3ce5	23.75 KiB	904.54 KiB	880.79 KiB
d23a1b1	23.75 KiB	913.64 KiB	889.88 KiB
2a6f451	23.75 KiB	913.13 KiB	889.38 KiB
0529194	23.74 KiB	891.02 KiB	867.28 KiB
2481950	23.74 KiB	872.74 KiB	849.00 KiB
f92cfa9	23.75 KiB	855.38 KiB	831.63 KiB
0b5fd21	23.75 KiB	912.78 KiB	889.03 KiB
7eafbde	23.75 KiB	927.53 KiB	903.78 KiB
c2982e7	23.75 KiB	911.62 KiB	887.87 KiB
82f60cf	23.75 KiB	913.63 KiB	889.88 KiB

Previous results on branch: itay/cocoa-552-convert-sentrybinaryimagecache-to-swift

Startup times

Revision	Plain	With Sentry	Diff
07e6529	1219.33 ms	1237.84 ms	18.50 ms
77a9688	1219.17 ms	1246.98 ms	27.81 ms
c1f4ce8	1232.10 ms	1247.84 ms	15.73 ms
8b2f8f3	1208.21 ms	1248.07 ms	39.86 ms
ad01f7a	1218.51 ms	1245.64 ms	27.13 ms
a70b125	1247.71 ms	1271.81 ms	24.10 ms

App size

Revision	Plain	With Sentry	Diff
07e6529	23.75 KiB	930.38 KiB	906.63 KiB
77a9688	23.75 KiB	931.89 KiB	908.15 KiB
c1f4ce8	23.75 KiB	930.75 KiB	907.01 KiB
8b2f8f3	23.75 KiB	931.23 KiB	907.49 KiB
ad01f7a	23.75 KiB	931.18 KiB	907.44 KiB
a70b125	23.75 KiB	930.71 KiB	906.96 KiB

[philprime]

LGTM, only a couple of comments left to consider

[github-actions]

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

• Sources/Sentry/SentryUIViewControllerSwizzling.m