Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7778 +/- ##
=============================================
+ Coverage 85.437% 85.451% +0.014%
=============================================
Files 487 487
Lines 29226 29227 +1
Branches 12645 12648 +3
=============================================
+ Hits 24970 24975 +5
+ Misses 4206 4202 -4
Partials 50 50 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0e4b033 | 1203.74 ms | 1249.71 ms | 45.97 ms |
| bbee1ba | 1197.79 ms | 1215.42 ms | 17.63 ms |
| 59981b9 | 1207.25 ms | 1240.71 ms | 33.46 ms |
| 64a365a | 1225.60 ms | 1255.49 ms | 29.89 ms |
| 93d7fdf | 1225.77 ms | 1259.79 ms | 34.02 ms |
| e03f459 | 1222.56 ms | 1255.94 ms | 33.37 ms |
| ffac605 | 1217.10 ms | 1256.91 ms | 39.81 ms |
| 2f4ddaa | 1227.26 ms | 1260.04 ms | 32.78 ms |
| 778dadf | 1207.69 ms | 1246.09 ms | 38.40 ms |
| daf8b80 | 1233.78 ms | 1259.44 ms | 25.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0e4b033 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| bbee1ba | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| 59981b9 | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| 64a365a | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| 93d7fdf | 24.14 KiB | 1.11 MiB | 1.08 MiB |
| e03f459 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| ffac605 | 24.14 KiB | 1.13 MiB | 1.10 MiB |
| 2f4ddaa | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 778dadf | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| daf8b80 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
itaybre
requested review from
noahsmartin,
philipphofmann and
philprime
as code owners
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ce93130. Configure here.
philprime
added a commit
that referenced
this pull request
Apr 23, 2026
Package@swift-6.2.swift (added in #7778 on main) is missing the SentryObjC/SentryObjCBridge subdirectory excludes for SentryObjCInternal, and the entire SentryObjC product + target block. Swift 6.2 tools (Xcode 26.3+) pick this manifest over Package.swift, so package resolution fails with "target at '.../Sources' contains mixed language source files" because SentryObjCBridge/ ships a Swift file while the rest of Sources/ is ObjC/C++. Add the two subdirectories to the SentryObjCInternal exclude list and append the SentryObjC library product along with its SentryObjCBridge and SentryObjC targets, mirroring the layout already present in Package.swift and Package@swift-6.1.swift. Refs GH-6342
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add a newer
Package@swift-6.2.swift, so newer SPM tools use it instead and allow using unsafe flags.💡 Motivation and Context
When using plain SPM, seems like using unsafe flags is disabled when swift tools is lower than 6.1
Fixes: #7738
💚 How did you test it?
Tested it with a sample project and using releases on a fork
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.