Conversation
…ublayers in iOS 26+
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7781 +/- ##
=============================================
+ Coverage 86.426% 86.457% +0.030%
=============================================
Files 487 487
Lines 40013 40066 +53
Branches 18014 18031 +17
=============================================
+ Hits 34582 34640 +58
+ Misses 5380 5376 -4
+ Partials 51 50 -1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2df6337 | 1237.50 ms | 1263.60 ms | 26.10 ms |
| 81f76c2 | 1216.40 ms | 1253.76 ms | 37.36 ms |
| b2f3bdd | 1219.09 ms | 1256.42 ms | 37.33 ms |
| 04540c5 | 1226.39 ms | 1251.40 ms | 25.02 ms |
| fe6228d | 1215.81 ms | 1234.04 ms | 18.23 ms |
| a1a9260 | 1192.15 ms | 1229.80 ms | 37.64 ms |
| 3bf0d3f | 1202.12 ms | 1237.23 ms | 35.11 ms |
| 60ea6f8 | 1209.42 ms | 1246.62 ms | 37.21 ms |
| a180235 | 1222.87 ms | 1255.10 ms | 32.23 ms |
| a8ec727 | 1217.78 ms | 1253.26 ms | 35.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2df6337 | 24.14 KiB | 1.13 MiB | 1.10 MiB |
| 81f76c2 | 24.14 KiB | 1.11 MiB | 1.08 MiB |
| b2f3bdd | 24.14 KiB | 1.11 MiB | 1.08 MiB |
| 04540c5 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| fe6228d | 24.14 KiB | 1.11 MiB | 1.08 MiB |
| a1a9260 | 24.14 KiB | 1.08 MiB | 1.06 MiB |
| 3bf0d3f | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 60ea6f8 | 24.14 KiB | 1.12 MiB | 1.10 MiB |
| a180235 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| a8ec727 | 24.14 KiB | 1.12 MiB | 1.10 MiB |
Previous results on branch: itay/session_replay_layer_based_redacting
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c74729d | 1209.42 ms | 1241.16 ms | 31.74 ms |
| 4f76092 | 1213.18 ms | 1234.17 ms | 20.99 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c74729d | 24.14 KiB | 1.14 MiB | 1.11 MiB |
| 4f76092 | 24.14 KiB | 1.13 MiB | 1.11 MiB |
…ssion_replay_layer_based_redacting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add's SwiftUI layers for text and images to automatically redact content on iOS 26
💡 Motivation and Context
iOS 26 only uses layers for rendering SwiftUI content, thus our old logic broke and stopped masking text and images.
Fixes: #6390
💚 How did you test it?
Used our SwiftUI app with
.sentryReplayPreviewMask(opacity: 0.5)Example iOS 18 vs iOS 26

📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.