feat(network-details): Add experimental flag and changelog#7854
Merged
feat(network-details): Add experimental flag and changelog#7854
Conversation
…k details capture Gate Session Replay network detail capture behind options.experimental.enableReplayNetworkDetailsCapturing to ensure users explicitly opt in to this new feature.
itaybre
requested review from
noahsmartin,
philipphofmann and
philprime
as code owners
Contributor
|
📲 Install BuildsiOS
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7854 +/- ##
=============================================
- Coverage 85.493% 85.482% -0.012%
=============================================
Files 487 487
Lines 29642 29647 +5
Branches 12844 12862 +18
=============================================
+ Hits 25342 25343 +1
- Misses 4249 4252 +3
- Partials 51 52 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| adef457 | 1229.45 ms | 1262.67 ms | 33.22 ms |
| 6c524d8 | 1217.83 ms | 1254.02 ms | 36.20 ms |
| e44b6f8 | 1225.98 ms | 1249.20 ms | 23.23 ms |
| 65c13c5 | 1234.47 ms | 1263.10 ms | 28.63 ms |
| 1c5ecda | 1219.35 ms | 1253.76 ms | 34.41 ms |
| ae8cece | 1216.83 ms | 1251.37 ms | 34.55 ms |
| 29d546e | 1224.06 ms | 1257.05 ms | 32.98 ms |
| ce1ec47 | 1212.60 ms | 1247.61 ms | 35.02 ms |
| 787537a | 1218.35 ms | 1251.72 ms | 33.38 ms |
| 71e6611 | 1213.27 ms | 1242.25 ms | 28.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| adef457 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 6c524d8 | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| e44b6f8 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 65c13c5 | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 1c5ecda | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| ae8cece | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 29d546e | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| ce1ec47 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 787537a | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 71e6611 | 24.14 KiB | 1.15 MiB | 1.12 MiB |
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
options.experimental.enableReplayNetworkDetailsCapturingflag to gate the Session Replay network details capture feature behind an explicit opt-innetworkDetailAllowUrls,networkDetailDenyUrls,networkCaptureBodies,networkRequestHeaders,networkResponseHeaders) noting the experimental flag requirementSentryEnabledFeaturesBuilderTest plan
SentryNetworkTrackerTestsupdated to set experimental flag for network detail assertionsmake build-iospassesmake test-iospasses