chore(samples): add package traits to macOS-CLI-Xcode sample config#8408
Merged
Conversation
Member
Author
|
Related issue: yonaskolb/XcodeGen#1585 |
📲 Install BuildsiOS
|
Generate the macOS CLI Xcode project from its XcodeGen specification before building it in CI. Install and cache the same build dependencies used by the other sample jobs.
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ce900e7 | 1212.40 ms | 1244.57 ms | 32.18 ms |
| af5922b | 1224.16 ms | 1250.40 ms | 26.24 ms |
| 16c51a6 | 1215.72 ms | 1256.65 ms | 40.93 ms |
| b32b02f | 1227.11 ms | 1249.68 ms | 22.57 ms |
| fc4e913 | 1231.79 ms | 1267.89 ms | 36.11 ms |
| 962c7bc | 1235.49 ms | 1262.79 ms | 27.30 ms |
| 8aae547 | 1238.51 ms | 1286.63 ms | 48.11 ms |
| cbc75eb | 1239.77 ms | 1270.89 ms | 31.12 ms |
| 67b09b7 | 1220.04 ms | 1258.27 ms | 38.23 ms |
| e9afedf | 1230.85 ms | 1263.42 ms | 32.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ce900e7 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| af5922b | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 16c51a6 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| b32b02f | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| fc4e913 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 962c7bc | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| 8aae547 | 24.14 KiB | 1.24 MiB | 1.22 MiB |
| cbc75eb | 24.14 KiB | 1.24 MiB | 1.22 MiB |
| 67b09b7 | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| e9afedf | 24.14 KiB | 1.17 MiB | 1.15 MiB |
philprime
marked this pull request as ready for review
July 20, 2026 07:42
philprime
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin and
philipphofmann
as code owners
July 20, 2026 07:43
philprime
enabled auto-merge (squash)
July 20, 2026 07:43
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 344ae78. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
The xcode-ci-macOS-CLI-Xcode target existed but was missing from the aggregate xcode-ci target. Since the .xcodeproj is now gitignored and generated via XcodeGen, make init/xcode-ci must generate it too.
Add the traits field to LocalPackage and RemotePackage in the XcodeGen schema. LocalPackage enumerates the Sentry SDK traits (NoUIFramework, V10, KSCrash) for autocomplete and validation.
NinjaLikesCheez
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Xcode project used for the sample
macOS-CLI-Xcoderequires the package trait toNoUIFrameworkto be set. The latest released xcodegen version 2.45.4 does not support package traits.I have created a contribution in the repository to add support with yonaskolb/XcodeGen#1629
After that pull request is merged and the change is released, we are able to merge this pull request too.
#skip-changelog
Closes #8465