feat(symbolication): upload dart symbol mapping file#347
Merged
Conversation
Contributor
|
buenaflor
commented
Aug 8, 2025
buenaflor
commented
Aug 12, 2025
denrase
requested changes
Aug 12, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
denrase
approved these changes
Aug 14, 2025
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
Neat, just glanced over and gave general feedback. Please also make sure we have all possible cases in _prependDebugIdMarkerToMapFile covered:
- file without marker
- file with other marker
- file with same marker
TODOs should also either be resolved or issues created for them, otherwise they might linger around forever and the next one might not have enough context to resolve them.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by getsentry/sentry-cli#2691
Blocked by #327
📜 Description
Adds support for uploading dart symbol maps
💡 Motivation and Context
Part of getsentry/sentry-dart#2805
💚 How did you test it?
Unit, integration, manual
📝 Checklist
🔮 Next steps