docs(js): Use split layout in Angular & SvelteKit quick start guide#17227
docs(js): Use split layout in Angular & SvelteKit quick start guide#17227inventarSarah merged 4 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
coolguyzone
left a comment
There was a problem hiding this comment.
Looks good, thanks for updating these!
JPeer264
left a comment
There was a problem hiding this comment.
Uh that looks way better. Thanks for updating
Lms24
left a comment
There was a problem hiding this comment.
Content-wise, this LGTM. I agree that it looks a bit better than before. However, I think we have some opportunities to clean up a lot of wasted space in the manual setup guides. For example, the CTAs to log in seem highly duplicated and push down the code blocks quite a bit:
Doesn't have to block this PR as this likely is a problem everywhere. But long-term, we should come up with a smarter concept here how to display this.
Yes, these come from the Code block component and are everywhere. |
DESCRIBE YOUR PR
This branch updates the following quick start guides to use the new split layout:
I created temporary include files for tunneling and source maps content (which I will clean up once all guides are updated). I then also updated the Browser JS quick start guide to use these new include files.
Closes: #17187
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES