Skip to content

Commit 45db870

Browse files
committed
Final clean up
1 parent b1a5777 commit 45db870

2 files changed

Lines changed: 10 additions & 43 deletions

File tree

test/Sentry.Android.AssemblyReader.Tests/AndroidAssemblyReaderTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ public void ReadsAssembly(bool isAot, bool isAssemblyStore, bool isCompressed, s
113113
Skip.If(!isAssemblyStore);
114114
Skip.If(!isCompressed);
115115
#endif
116-
117-
Skip.If(isAot && RuntimeInformation.IsOSPlatform(OSPlatform.Windows), "Android AOT is not supported on Windows");
116+
Skip.If(isAot && RuntimeInformation.IsOSPlatform(OSPlatform.Windows), "Cross-OS native compilation is not supported on Windows");
118117

119118
using var sut = GetSut(isAot, isAssemblyStore, isCompressed);
120119

test/Sentry.Android.AssemblyReader.Tests/Sentry.Android.AssemblyReader.Tests.csproj

Lines changed: 9 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -32,47 +32,15 @@
3232
</Target>
3333
<Target Name="_InnerBuildTestAPKs">
3434
<ItemGroup>
35-
<_TestAPK Include="1">
36-
<Aot>False</Aot>
37-
<Store>False</Store>
38-
<Compressed>False</Compressed>
39-
</_TestAPK>
40-
<_TestAPK Include="2">
41-
<Aot>False</Aot>
42-
<Store>False</Store>
43-
<Compressed>True</Compressed>
44-
</_TestAPK>
45-
<_TestAPK Include="3">
46-
<Aot>False</Aot>
47-
<Store>True</Store>
48-
<Compressed>False</Compressed>
49-
</_TestAPK>
50-
<_TestAPK Include="4">
51-
<Aot>False</Aot>
52-
<Store>True</Store>
53-
<Compressed>True</Compressed>
54-
</_TestAPK>
55-
56-
<_TestAPK Include="5" Condition="!$([MSBuild]::IsOSPlatform('Windows'))">
57-
<Aot>True</Aot>
58-
<Store>False</Store>
59-
<Compressed>False</Compressed>
60-
</_TestAPK>
61-
<_TestAPK Include="6" Condition="!$([MSBuild]::IsOSPlatform('Windows'))">
62-
<Aot>True</Aot>
63-
<Store>False</Store>
64-
<Compressed>True</Compressed>
65-
</_TestAPK>
66-
<_TestAPK Include="7" Condition="!$([MSBuild]::IsOSPlatform('Windows'))">
67-
<Aot>True</Aot>
68-
<Store>True</Store>
69-
<Compressed>False</Compressed>
70-
</_TestAPK>
71-
<_TestAPK Include="8" Condition="!$([MSBuild]::IsOSPlatform('Windows'))">
72-
<Aot>True</Aot>
73-
<Store>True</Store>
74-
<Compressed>True</Compressed>
75-
</_TestAPK>
35+
<_TestAPK Include="1" Aot="False" Store="False" Compressed="False" />
36+
<_TestAPK Include="2" Aot="False" Store="False" Compressed="True" />
37+
<_TestAPK Include="3" Aot="False" Store="True" Compressed="False" />
38+
<_TestAPK Include="4" Aot="False" Store="True" Compressed="True" />
39+
<!-- Cross-OS native compilation is not supported on Windows (Microsoft.NETCore.Native.Publish.targets). -->
40+
<_TestAPK Include="5" Aot="True" Store="False" Compressed="False" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
41+
<_TestAPK Include="6" Aot="True" Store="False" Compressed="True" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
42+
<_TestAPK Include="7" Aot="True" Store="True" Compressed="False" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
43+
<_TestAPK Include="8" Aot="True" Store="True" Compressed="True" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
7644
</ItemGroup>
7745

7846
<MSBuild Projects="$(MSBuildProjectFile)"

0 commit comments

Comments
 (0)