fix: Allow Sentry failures when SENTRY_ALLOW_FAILURE is set in the Sentry CLI (#4852)

* fix(targets): fix #4849 by adding support for SENTRY_ALLOW_FAILURE

* fix(targets): add allow failure in propose-version

* ref(targets): tweak target check based on review

* fix(targets): fix allow failure check correctly

* Update CHANGELOG with new features and fixes

Added a section for fixes and documented a new feature and dependency update.

---------

Co-authored-by: Daniel McAssey <dmcassey@jigsawcreate.com>
Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>

Author: 3 people

CHANGELOG.md

@@ -8,6 +8,7 @@
 
 ### Fixes
 
+- Allow Sentry failures from the Sentry CLI when SENTRY_ALLOW_FAILURE is set ([#4852](https://github.com/getsentry/sentry-dotnet/pull/4852))
 - The SDK now logs a specific error message when envelopes are rejected due to size limits (HTTP 413) ([#4863](https://github.com/getsentry/sentry-dotnet/pull/4863))
 - Fixed thread-safety issue on Android when multiple events are captured concurrently ([#4814](https://github.com/getsentry/sentry-dotnet/pull/4814))
 

src/Sentry/buildTransitive/Sentry.targets

@@ -19,6 +19,7 @@
   <PropertyGroup>
     <SentryAttributesFile>Sentry.Attributes$(MSBuildProjectExtension.Replace('proj', ''))</SentryAttributesFile>
     <SentryProGuardUUID Condition="'$(SentryProGuardUUID)' == ''">$([System.Guid]::NewGuid())</SentryProGuardUUID>
+    <SentryAllowFailure Condition="'$(SENTRY_ALLOW_FAILURE)' == 'true'">true</SentryAllowFailure>
   </PropertyGroup>
 
   <Target Name="_SentryEnsureAndroidEnableAssemblyCompressionDisabled"
@@ -360,7 +361,9 @@
     </SentryGetApplicationVersion>
 
     <Exec ConsoleToMSBuild="true"  Condition="'$(_SentryRelease)' == ''"
-          Command="sentry-cli releases propose-version">
+          Command="sentry-cli releases propose-version"
+          IgnoreExitCode="$(SentryAllowFailure)"
+          ContinueOnError="$(SentryAllowFailure)">
       <Output TaskParameter="ConsoleOutput" PropertyName="_SentryRelease"/>
     </Exec>
 
@@ -369,7 +372,7 @@
 
   <!-- Set release information after the build -->
   <Target Name="_CreateSentryRelease" AfterTargets="Build" DependsOnTargets="_GetSentryRelease"
-          Condition="'$(SentryCLI)' != '' and '$(SentryCreateRelease)' == 'true'">
+          Condition="'$(SentryCLI)' != '' and '$(SentryCreateRelease)' == 'true' and '$(_SentryRelease)' != ''">
     <Message Importance="High" Text="Creating Sentry Release: $(_SentryRelease)" />
     <Exec
       Command="$(SentryCLIBaseCommand) releases new $(_SentryRelease) $(SentryReleaseOptions)"
@@ -380,7 +383,7 @@
 
   <!-- Send commit details to Sentry -->
   <Target Name="_SentrySetCommits" AfterTargets="Build" DependsOnTargets="_CreateSentryRelease"
-          Condition="'$(SentryCLI)' != '' and '$(SentrySetCommits)' == 'true'">
+          Condition="'$(SentryCLI)' != '' and '$(SentrySetCommits)' == 'true' and '$(_SentryRelease)' != ''">
     <Message Importance="High" Text="Setting Sentry commits" />
     <Exec
       Command="$(SentryCLIBaseCommand) releases set-commits $(SentrySetCommitOptions) $(_SentryRelease) $(SentrySetCommitReleaseOptions)"