fix: [.NET 10] PageNavigationExtensions updated for public Page properties (#5278)

* fixes 4578

starting with .NET 10 DestinationPage and PreviousPage in NavigatedFromEventArgs and NavigatedToEventArgs are no longer internal so no need for getting them via reflection in PageNavigationExtensions.

Author: nor0x

src/Sentry.Maui/Internal/PageNavigationExtensions.cs

@@ -4,6 +4,7 @@ namespace Sentry.Maui.Internal;
 
 internal static class PageNavigationExtensions
 {
+#if !NET10_0_OR_GREATER
     private static readonly PropertyInfo? DestinationPageProperty;
     private static readonly PropertyInfo? PreviousPageProperty;
 
@@ -19,18 +20,25 @@ static PageNavigationExtensions()
         PreviousPageProperty = typeof(NavigatedToEventArgs)
             .GetProperty("PreviousPage", BindingFlags.Instance | BindingFlags.NonPublic);
     }
+#endif
 
     /// <summary>
-    /// Reads the (internal) NavigatedFromEventArgs.DestinationPage property via reflection.
-    /// Note that this will return null if trimming is enabled.
+    /// Gets the destination page from navigation arguments.
     /// </summary>
     public static Page? GetDestinationPage(this NavigatedFromEventArgs eventArgs) =>
+#if NET10_0_OR_GREATER
+        eventArgs.DestinationPage;
+#else
         DestinationPageProperty?.GetValue(eventArgs) as Page;
+#endif
 
     /// <summary>
-    /// Reads the (internal) NavigatedFromEventArgs.PreviousPage property via reflection.
-    /// Note that this will return null if trimming is enabled.
+    /// Gets the previous page from navigation arguments.
     /// </summary>
     public static Page? GetPreviousPage(this NavigatedToEventArgs eventArgs) =>
+#if NET10_0_OR_GREATER
+        eventArgs.PreviousPage;
+#else
         PreviousPageProperty?.GetValue(eventArgs) as Page;
+#endif
 }

test/Sentry.Maui.Tests/MauiEventsBinderTests.Page.cs

@@ -88,11 +88,8 @@ public void Page_NavigatedTo_AddsBreadcrumb()
         Assert.Equal(MauiEventsBinder.NavigationType, crumb.Type);
         Assert.Equal(MauiEventsBinder.NavigationCategory, crumb.Category);
         crumb.Data.Should().Contain($"{nameof(Page)}.Name", "page");
-#if !NET10_0
-        // TODO: Work out why these are missing in .NET 10
         crumb.Data.Should().Contain("PreviousPage", nameof(Page));
         crumb.Data.Should().Contain("PreviousPage.Name", "otherPage");
-#endif
     }
 
     [Fact]