Skip to content

Commit f5df109

Browse files
github-actions[bot]web-flowjamescrosswellclaude
authored
chore(deps): update Java SDK to v8.42.0 (#5208)
* chore: update scripts/update-java.ps1 to 8.42.0 * fix(android): drop deprecated SentryUserFeedbackDialog bindings The Java SDK 8.41 release deprecated SentryUserFeedbackDialog in favor of SentryUserFeedbackForm. The auto-generated C# bindings now produce CS0108 collisions because Dialog's nested IOptionsConfiguration / IOptionsConfigurationInvoker share names with the ones on Form, and Form's nested Builder collides with the inherited AlertDialog.Builder. Remove the deprecated Dialog tree (we never exposed it) and rename Form's nested Builder to SentryUserFeedbackFormBuilder so it no longer shadows the inherited member. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: James Crosswell <james.crosswell@gmail.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 598fdba commit f5df109

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<TargetFrameworks>$(LatestAndroidTfm);$(PreviousAndroidTfm)</TargetFrameworks>
4-
<SentryAndroidSdkVersion>8.40.0</SentryAndroidSdkVersion>
4+
<SentryAndroidSdkVersion>8.42.0</SentryAndroidSdkVersion>
55
<SentryAndroidSdkDirectory>$(BaseIntermediateOutputPath)sdks\$(TargetFramework)\Sentry\Android\$(SentryAndroidSdkVersion)\</SentryAndroidSdkDirectory>
66
<!-- This gets resolved by the DownloadSentryAndroidSdk unless using local maven references -->
77
<SentryNativeNdkVersion></SentryNativeNdkVersion>

src/Sentry.Bindings.Android/Transforms/Metadata.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,13 @@
147147
<remove-node path="/api/package[@name='io.sentry.android.core.cache']/class[@name='AndroidEnvelopeCache']" />
148148
<remove-node path="/api/package[@name='io.sentry.android.core.internal.gestures']" />
149149
<remove-node path="/api/package[@name='io.sentry.android.core.performance']" />
150-
<remove-node path="/api/package[@name='io.sentry.android.core']/class[@name='SentryUserFeedbackDialog.Builder']" />
150+
<!-- Remove the deprecated SentryUserFeedbackDialog (and its nested types). Replaced by SentryUserFeedbackForm in Java SDK 8.41+.
151+
The nested IOptionsConfiguration / IOptionsConfigurationInvoker collide with the same-named types on SentryUserFeedbackForm (CS0108). -->
152+
<remove-node path="/api/package[@name='io.sentry.android.core']/class[starts-with(@name,'SentryUserFeedbackDialog')]" />
153+
154+
<!-- SentryUserFeedbackForm extends AlertDialog and declares a nested Builder that extends AlertDialog.Builder.
155+
Rename the nested type so its C# name no longer collides with the inherited AlertDialog.Builder (CS0108). -->
156+
<attr path="/api/package[@name='io.sentry.android.core']/class[@name='SentryUserFeedbackForm.Builder']" name="managedName">SentryUserFeedbackFormBuilder</attr>
151157

152158
<remove-node path="/api/package[starts-with(@name,'io.sentry')]/*/method[@name='clone' and count(parameter)=0]" />
153159
<remove-node path="/api/package[starts-with(@name,'io.sentry')]/class/implements[@name='io.sentry.JsonDeserializer']" />

0 commit comments

Comments
 (0)