Skip to content

Commit fbbb84a

Browse files
committed
Restore net8 checks
1 parent 45db870 commit fbbb84a

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

test/Sentry.Android.AssemblyReader.Tests/AndroidAssemblyReaderTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ public void ReadsAssembly(bool isAot, bool isAssemblyStore, bool isCompressed, s
113113
Skip.If(!isAssemblyStore);
114114
Skip.If(!isCompressed);
115115
#endif
116-
Skip.If(isAot && RuntimeInformation.IsOSPlatform(OSPlatform.Windows), "Cross-OS native compilation is not supported on Windows");
117116

118117
using var sut = GetSut(isAot, isAssemblyStore, isCompressed);
119118

test/Sentry.Android.AssemblyReader.Tests/Sentry.Android.AssemblyReader.Tests.csproj

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,10 @@
3636
<_TestAPK Include="2" Aot="False" Store="False" Compressed="True" />
3737
<_TestAPK Include="3" Aot="False" Store="True" Compressed="False" />
3838
<_TestAPK Include="4" Aot="False" Store="True" Compressed="True" />
39-
<!-- Cross-OS native compilation is not supported on Windows (Microsoft.NETCore.Native.Publish.targets). -->
40-
<_TestAPK Include="5" Aot="True" Store="False" Compressed="False" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
41-
<_TestAPK Include="6" Aot="True" Store="False" Compressed="True" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
42-
<_TestAPK Include="7" Aot="True" Store="True" Compressed="False" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
43-
<_TestAPK Include="8" Aot="True" Store="True" Compressed="True" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" />
39+
<_TestAPK Include="5" Aot="True" Store="False" Compressed="False" Condition="!$(TargetFramework.StartsWith('net8'))" />
40+
<_TestAPK Include="6" Aot="True" Store="False" Compressed="True" Condition="!$(TargetFramework.StartsWith('net8'))" />
41+
<_TestAPK Include="7" Aot="True" Store="True" Compressed="False" Condition="!$(TargetFramework.StartsWith('net8'))" />
42+
<_TestAPK Include="8" Aot="True" Store="True" Compressed="True" Condition="!$(TargetFramework.StartsWith('net8'))" />
4443
</ItemGroup>
4544

4645
<MSBuild Projects="$(MSBuildProjectFile)"

0 commit comments

Comments
 (0)