Skip to content

fix(span): deprecation notice #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruno-garcia merged 3 commits into from
Jul 12, 2025
Merged

fix(span): deprecation notice #4336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1a8f82
fix(span): deprecation notice
bruno-garcia Jul 10, 2025
3a282a3
Update API approval snapshot tests for deprecation notice changes
cursoragent Jul 11, 2025
e252e1b
Merge remote-tracking branch 'origin' into fix/deprecation-notice
bruno-garcia Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Sentry/SentrySpan.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ public void SetData(string key, object? value) =>
(_data ??= new Dictionary<string, object?>())[key] = value;

/// <inheritdoc />
[Obsolete("Use SetData")]
[Obsolete("Use Data")]
public IReadOnlyDictionary<string, object?> Extra => Data;

/// <inheritdoc />
[Obsolete("Use Data")]
[Obsolete("Use SetData")]
public void SetExtra(string key, object? value) => SetData(key, value);

/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ namespace Sentry
public System.Collections.Generic.IReadOnlyDictionary<string, object?> Data { get; }
public string? Description { get; set; }
public System.DateTimeOffset? EndTimestamp { get; }
[System.Obsolete("Use SetData")]
[System.Obsolete("Use Data")]
public System.Collections.Generic.IReadOnlyDictionary<string, object?> Extra { get; }
public bool IsFinished { get; }
public bool? IsSampled { get; }
Expand All @@ -915,7 +915,7 @@ namespace Sentry
public Sentry.SentryId TraceId { get; }
public Sentry.SentryTraceHeader GetTraceHeader() { }
public void SetData(string key, object? value) { }
[System.Obsolete("Use Data")]
[System.Obsolete("Use SetData")]
public void SetExtra(string key, object? value) { }
public void SetMeasurement(string name, Sentry.Protocol.Measurement measurement) { }
public void SetTag(string key, string value) { }
Expand Down
4 changes: 2 additions & 2 deletions test/Sentry.Tests/ApiApprovalTests.Run.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ namespace Sentry
public System.Collections.Generic.IReadOnlyDictionary<string, object?> Data { get; }
public string? Description { get; set; }
public System.DateTimeOffset? EndTimestamp { get; }
[System.Obsolete("Use SetData")]
[System.Obsolete("Use Data")]
public System.Collections.Generic.IReadOnlyDictionary<string, object?> Extra { get; }
public bool IsFinished { get; }
public bool? IsSampled { get; }
Expand All @@ -915,7 +915,7 @@ namespace Sentry
public Sentry.SentryId TraceId { get; }
public Sentry.SentryTraceHeader GetTraceHeader() { }
public void SetData(string key, object? value) { }
[System.Obsolete("Use Data")]
[System.Obsolete("Use SetData")]
public void SetExtra(string key, object? value) { }
public void SetMeasurement(string name, Sentry.Protocol.Measurement measurement) { }
public void SetTag(string key, string value) { }
Expand Down
4 changes: 2 additions & 2 deletions test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ namespace Sentry
public System.Collections.Generic.IReadOnlyDictionary<string, object?> Data { get; }
public string? Description { get; set; }
public System.DateTimeOffset? EndTimestamp { get; }
[System.Obsolete("Use SetData")]
[System.Obsolete("Use Data")]
public System.Collections.Generic.IReadOnlyDictionary<string, object?> Extra { get; }
public bool IsFinished { get; }
public bool? IsSampled { get; }
Expand All @@ -896,7 +896,7 @@ namespace Sentry
public Sentry.SentryId TraceId { get; }
public Sentry.SentryTraceHeader GetTraceHeader() { }
public void SetData(string key, object? value) { }
[System.Obsolete("Use Data")]
[System.Obsolete("Use SetData")]
public void SetExtra(string key, object? value) { }
public void SetMeasurement(string name, Sentry.Protocol.Measurement measurement) { }
public void SetTag(string key, string value) { }
Expand Down
Loading