Skip to content

ci: always upload build logs #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpnurmi merged 4 commits into from
Jul 17, 2025
Merged

ci: always upload build logs #4358

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b419b5d
ci: always upload build logs
jpnurmi Jul 16, 2025
bc9f1a5
if-no-files-found: warn
jpnurmi Jul 17, 2025
203cc06
add missing build.log
jpnurmi Jul 17, 2025
89f370d
ignore instead of warning (still prints a message)
jpnurmi Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,14 @@ jobs:
run: dotnet build ${{ matrix.slnf }} -c Release --no-restore --nologo -v:minimal -flp:logfile=build.log -p:CopyLocalLockFileAssemblies=true -bl:build.binlog

- name: Upload build logs
if: ${{ steps.build.outcome != 'skipped' }}
if: ${{ always() }}
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.rid }}-build-logs
path: build.binlog
path: |
build.log
build.binlog
if-no-files-found: ignore

- name: Test
run: dotnet test ${{ matrix.slnf }} -c Release --no-build --nologo -l GitHubActions -l "trx;LogFilePrefix=testresults_${{ runner.os }}" --collect "XPlat Code Coverage"
Expand Down Expand Up @@ -269,13 +272,14 @@ jobs:
run: msbuild Sentry-CI-Build-Windows.slnf -t:Restore,Build -p:Configuration=Release --nologo -v:minimal -flp:logfile=msbuild.log -p:CopyLocalLockFileAssemblies=true -bl:msbuild.binlog

- name: Upload logs
if: ${{ steps.msbuild.outcome != 'skipped' }}
if: ${{ always() }}
uses: actions/upload-artifact@v4
with:
name: ${{ runner.os }}-msbuild-logs
path: |
msbuild.log
msbuild.binlog
if-no-files-found: ignore

trim-analysis:
needs: build-sentry-native
Expand Down
Loading