Skip to content

ci: fix msbuild cache key and clean up unused matrix properties #4367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpnurmi merged 2 commits into from
Jul 18, 2025
Merged

ci: fix msbuild cache key and clean up unused matrix properties #4367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba150a0
ci: fix msbuild cache key and clean up unused matrix properties
jpnurmi Jul 17, 2025
f3ce4e7
Fix inconsistent step name
jpnurmi Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,8 @@ jobs:
rid: linux-x64
- os: ubuntu-22.04-arm
rid: linux-arm64
target: Linux-arm64
- os: ubuntu-latest
rid: linux-musl-x64
target: Linux-musl
container:
image: ghcr.io/getsentry/sentry-dotnet-alpine:3.21
- os: macos-15 # Pin macos to get the version of Xcode that we need: https://github.com/actions/runner-images/issues/10703
Expand All @@ -35,7 +33,6 @@ jobs:
rid: win-x64
- os: windows-11-arm
rid: win-arm64
target: Windows-arm64

steps:
- name: Checkout
Expand Down Expand Up @@ -251,11 +248,11 @@ jobs:
with:
submodules: recursive

- name: Download sentry-native (Windows)
- name: Download sentry-native (win-x64)
Comment thread
jpnurmi marked this conversation as resolved.
uses: actions/cache/restore@v4
with:
path: src/Sentry/Platforms/Native/sentry-native
key: sentry-native-Windows-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }}
key: sentry-native-win-x64-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }}
fail-on-cache-miss: true
enableCrossOsArchive: true

Expand Down Expand Up @@ -298,7 +295,7 @@ jobs:
- name: Set Environment Variables
run: echo "CI_PUBLISHING_BUILD=true" >> $GITHUB_ENV

- name: Download sentry-native (macOS)
- name: Download sentry-native (macos)
uses: actions/cache/restore@v4
with:
path: src/Sentry/Platforms/Native/sentry-native
Expand Down
Loading