Skip to content

ci: install zstd for win arm64 straight from github releases#4369

Merged
jamescrosswell merged 1 commit intomainfrom
ci/win-arm64-zstd
Jul 20, 2025
Merged

ci: install zstd for win arm64 straight from github releases#4369
jamescrosswell merged 1 commit intomainfrom
ci/win-arm64-zstd

Conversation

@jpnurmi
Copy link
Copy Markdown
Collaborator

@jpnurmi jpnurmi commented Jul 18, 2025

Essentially does the same as what Chocolatey did under the hood [1], but replaces Chocolatey API requests with one blazing-fast direct GitHub HTTP request.

Before After
image image

References:

  1. https://community.chocolatey.org/packages/zstandard#files

Fixes: #4368

#skip-changelog

@jpnurmi jpnurmi force-pushed the ci/win-arm64-zstd branch from 0201303 to 78e48c4 Compare July 18, 2025 10:35
@jpnurmi jpnurmi marked this pull request as ready for review July 18, 2025 12:22
Copy link
Copy Markdown
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpnurmi !

@jamescrosswell jamescrosswell merged commit a09c27d into main Jul 20, 2025
31 checks passed
@jamescrosswell jamescrosswell deleted the ci/win-arm64-zstd branch July 20, 2025 22:15
if: runner.os == 'Windows' && runner.arch == 'ARM64'
shell: pwsh
env:
ZSTD_VERSION: ${{ inputs.version }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to use sha pinning here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for flagging it. we can should verify the checksum. would this do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent errors setting up environment for Win ARM64

3 participants