Skip to content

Disable Profiler_MultipleProfiles_Works in CI (flaky) #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 6 commits into from
Aug 22, 2025
Merged

Disable Profiler_MultipleProfiles_Works in CI (flaky) #4383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ebb5f30
Disable Profiler_MultipleProfiles_Works in CI (flaky)
jamescrosswell Jul 23, 2025
da86004
Merge branch 'main' into skip-flaky-test-4371
jamescrosswell Aug 15, 2025
30e9883
Merge branch 'main' into skip-flaky-test-4371
jamescrosswell Aug 20, 2025
2e90dee
Skip Profiler_WithZeroStartupTimeout_CapturesAfterStartingAsynchronou…
jamescrosswell Aug 20, 2025
3a71784
.
jamescrosswell Aug 20, 2025
8dcdbee
.
jamescrosswell Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ private SampleProfile CaptureAndValidate(ITransactionProfilerFactory factory)
[SkippableFact]
public void Profiler_WithZeroStartupTimeout_CapturesAfterStartingAsynchronously()
{
if (TestEnvironment.IsGitHubActions)
{
Skip.If(TestEnvironment.IsWinX64, "Flaky in CI on Windows X64.");
Skip.If(RuntimeInformation.IsOSPlatform(OSPlatform.Linux), "Flaky in CI on Linux.");
}

using var factory = new SamplingTransactionProfilerFactory(_testSentryOptions, TimeSpan.Zero);
var profiler = factory.Start(new TransactionTracer(Substitute.For<IHub>(), "test", ""), CancellationToken.None);
Assert.Null(profiler);
Expand Down Expand Up @@ -146,6 +152,8 @@ private void Profiler_SingleProfile_Works(int startTimeoutSeconds)
[InlineData(10)]
public void Profiler_MultipleProfiles_Works(int startTimeoutSeconds)
{
Skip.If(TestEnvironment.IsGitHubActions, "Flaky in CI");

using var factory = new SamplingTransactionProfilerFactory(_testSentryOptions, TimeSpan.FromSeconds(startTimeoutSeconds));
// in the async startup case, we need to wait before collecting
if (startTimeoutSeconds == 0)
Expand Down
3 changes: 3 additions & 0 deletions test/Sentry.Testing/TestEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,7 @@ public static bool IsGitHubActions
return isGitHubActions?.Equals("true", StringComparison.OrdinalIgnoreCase) == true;
}
}

public static bool IsWinX64 => RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
&& RuntimeInformation.OSArchitecture == Architecture.X64;
}
Loading