Skip to content

Skip Profiler_MultipleProfiles_Works test in CI #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamescrosswell wants to merge 1 commit into from
Closed

Skip Profiler_MultipleProfiles_Works test in CI #4405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
{
using var factory = new SamplingTransactionProfilerFactory(_testSentryOptions, TimeSpan.Zero);
var profiler = factory.Start(new TransactionTracer(Substitute.For<IHub>(), "test", ""), CancellationToken.None);
Assert.Null(profiler);

Check failure on line 122 in test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs

View workflow job for this annotation

GitHub Actions / .NET (linux-musl-x64)

Sentry.Profiling.Tests.SamplingTransactionProfilerTests.Profiler_WithZeroStartupTimeout_CapturesAfterStartingAsynchronously 

Assert.Null() Failure: Value is not null
Expected: null
Actual:   SamplingTransactionProfiler { OnFinish = Action { Method = Void <Start>b__11_0(), Target = SamplingTransactionProfilerFactory { ··· } } }

Check failure on line 122 in test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs

View workflow job for this annotation

GitHub Actions / .NET (linux-arm64)

Sentry.Profiling.Tests.SamplingTransactionProfilerTests.Profiler_WithZeroStartupTimeout_CapturesAfterStartingAsynchronously 

Assert.Null() Failure: Value is not null
Expected: null
Actual:   SamplingTransactionProfiler { OnFinish = Action { Method = Void <Start>b__11_0(), Target = SamplingTransactionProfilerFactory { ··· } } }

Check failure on line 122 in test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs

View workflow job for this annotation

GitHub Actions / .NET (linux-x64)

Sentry.Profiling.Tests.SamplingTransactionProfilerTests.Profiler_WithZeroStartupTimeout_CapturesAfterStartingAsynchronously 

Assert.Null() Failure: Value is not null
Expected: null
Actual:   SamplingTransactionProfiler { OnFinish = Action { Method = Void <Start>b__11_0(), Target = SamplingTransactionProfilerFactory { ··· } } }

Check failure on line 122 in test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs

View workflow job for this annotation

GitHub Actions / .NET (linux-x64)

Sentry.Profiling.Tests.SamplingTransactionProfilerTests.Profiler_WithZeroStartupTimeout_CapturesAfterStartingAsynchronously 

Assert.Null() Failure: Value is not null
Expected: null
Actual:   SamplingTransactionProfiler { OnFinish = Action { Method = Void <Start>b__11_0(), Target = SamplingTransactionProfilerFactory { ··· } } }
SkipIfFailsInCI(() => factory._sessionTask.Wait(60_000));
CaptureAndValidate(factory);
}
Expand All @@ -146,6 +146,8 @@
[InlineData(10)]
public void Profiler_MultipleProfiles_Works(int startTimeoutSeconds)
{
Skip.If(TestEnvironment.IsGitHubActions, "Flaky on CI");

using var factory = new SamplingTransactionProfilerFactory(_testSentryOptions, TimeSpan.FromSeconds(startTimeoutSeconds));
// in the async startup case, we need to wait before collecting
if (startTimeoutSeconds == 0)
Expand Down
Loading