From 1af6def210f4da53e51940b1bd1e615f8e8b5312 Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Wed, 6 Aug 2025 21:28:21 +1200 Subject: [PATCH 1/2] chore: Skip AndroidAssemblyReaderTests on Windows Resolves #4091: - https://github.com/getsentry/sentry-dotnet/issues/4091#issuecomment-3158445772 #skip-changelog --- Sentry-CI-Build-Windows-arm64.slnf | 1 - Sentry-CI-Build-Windows.slnf | 1 - scripts/generate-solution-filters-config.yaml | 2 ++ 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Sentry-CI-Build-Windows-arm64.slnf b/Sentry-CI-Build-Windows-arm64.slnf index c1f6bd735d..baac3fedfb 100644 --- a/Sentry-CI-Build-Windows-arm64.slnf +++ b/Sentry-CI-Build-Windows-arm64.slnf @@ -55,7 +55,6 @@ "src\\Sentry.SourceGenerators\\Sentry.SourceGenerators.csproj", "src\\Sentry\\Sentry.csproj", "test\\Sentry.Analyzers.Tests\\Sentry.Analyzers.Tests.csproj", - "test\\Sentry.Android.AssemblyReader.Tests\\Sentry.Android.AssemblyReader.Tests.csproj", "test\\Sentry.AspNet.Tests\\Sentry.AspNet.Tests.csproj", "test\\Sentry.AspNetCore.Grpc.Tests\\Sentry.AspNetCore.Grpc.Tests.csproj", "test\\Sentry.AspNetCore.Tests\\Sentry.AspNetCore.Tests.csproj", diff --git a/Sentry-CI-Build-Windows.slnf b/Sentry-CI-Build-Windows.slnf index d5960f2212..677a8f0608 100644 --- a/Sentry-CI-Build-Windows.slnf +++ b/Sentry-CI-Build-Windows.slnf @@ -55,7 +55,6 @@ "src\\Sentry.SourceGenerators\\Sentry.SourceGenerators.csproj", "src\\Sentry\\Sentry.csproj", "test\\Sentry.Analyzers.Tests\\Sentry.Analyzers.Tests.csproj", - "test\\Sentry.Android.AssemblyReader.Tests\\Sentry.Android.AssemblyReader.Tests.csproj", "test\\Sentry.AspNet.Tests\\Sentry.AspNet.Tests.csproj", "test\\Sentry.AspNetCore.Grpc.Tests\\Sentry.AspNetCore.Grpc.Tests.csproj", "test\\Sentry.AspNetCore.Tests\\Sentry.AspNetCore.Tests.csproj", diff --git a/scripts/generate-solution-filters-config.yaml b/scripts/generate-solution-filters-config.yaml index da07eaaa75..2f9c6b4784 100644 --- a/scripts/generate-solution-filters-config.yaml +++ b/scripts/generate-solution-filters-config.yaml @@ -96,6 +96,7 @@ filterConfigs: - "trimTests" patterns: - "**/*AndroidTestApp.csproj" + - "**/*Sentry.Android.AssemblyReader.Tests.csproj" - "**/*DeviceTests*.csproj" - "**/*Sentry.Maui.Device.TestApp.csproj" - "**/*Sentry.Samples.Android.csproj" @@ -115,6 +116,7 @@ filterConfigs: - "trimTests" patterns: - "**/*AndroidTestApp.csproj" + - "**/*Sentry.Android.AssemblyReader.Tests.csproj" - "**/*DeviceTests*.csproj" - "**/*Sentry.Maui.Device.TestApp.csproj" - "**/*Sentry.Samples.Android.csproj" From 07e9030992f10d6216adf2a35bbea3146cb71916 Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Mon, 11 Aug 2025 10:15:40 +1200 Subject: [PATCH 2/2] Update generate-solution-filters-config.yaml --- scripts/generate-solution-filters-config.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/generate-solution-filters-config.yaml b/scripts/generate-solution-filters-config.yaml index 2f9c6b4784..45c95d8f4b 100644 --- a/scripts/generate-solution-filters-config.yaml +++ b/scripts/generate-solution-filters-config.yaml @@ -96,6 +96,7 @@ filterConfigs: - "trimTests" patterns: - "**/*AndroidTestApp.csproj" + # AssemblyReader tests are flaky on Windows: https://github.com/getsentry/sentry-dotnet/issues/4091 - "**/*Sentry.Android.AssemblyReader.Tests.csproj" - "**/*DeviceTests*.csproj" - "**/*Sentry.Maui.Device.TestApp.csproj" @@ -116,6 +117,7 @@ filterConfigs: - "trimTests" patterns: - "**/*AndroidTestApp.csproj" + # AssemblyReader tests are flaky on Windows: https://github.com/getsentry/sentry-dotnet/issues/4091 - "**/*Sentry.Android.AssemblyReader.Tests.csproj" - "**/*DeviceTests*.csproj" - "**/*Sentry.Maui.Device.TestApp.csproj"