Skip to content

test: disabled win-x64 test on win-arm64 too #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flash0ver merged 1 commit into from
Aug 25, 2025
Merged

test: disabled win-x64 test on win-arm64 too #4464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public void Profiler_WithZeroStartupTimeout_CapturesAfterStartingAsynchronously(
{
if (TestEnvironment.IsGitHubActions)
{
Skip.If(TestEnvironment.IsWinX64, "Flaky in CI on Windows X64.");
Skip.If(RuntimeInformation.IsOSPlatform(OSPlatform.Windows), "Flaky in CI on Windows.");
Skip.If(RuntimeInformation.IsOSPlatform(OSPlatform.Linux), "Flaky in CI on Linux.");
}

Expand Down
5 changes: 0 additions & 5 deletions test/Sentry.Testing/TestEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
using System;

namespace Sentry.Testing;

public static class TestEnvironment
Expand All @@ -15,7 +13,4 @@ public static bool IsGitHubActions
return isGitHubActions?.Equals("true", StringComparison.OrdinalIgnoreCase) == true;
}
}

public static bool IsWinX64 => RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
&& RuntimeInformation.OSArchitecture == Architecture.X64;
}
Loading