chore: Suppress Xcode version validation for No-Mobile Solution#5054
chore: Suppress Xcode version validation for No-Mobile Solution#5054jamescrosswell merged 1 commit intomainfrom
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5054 +/- ##
==========================================
+ Coverage 74.00% 74.02% +0.02%
==========================================
Files 499 499
Lines 18048 18048
Branches 3512 3512
==========================================
+ Hits 13356 13360 +4
+ Misses 3838 3831 -7
- Partials 854 857 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| <PropertyGroup Condition="'$(SolutionName)' == '.generated.NoMobile'"> | ||
| <NO_MOBILE>true</NO_MOBILE> | ||
| <ValidateXcodeVersion>false</ValidateXcodeVersion> |
There was a problem hiding this comment.
question: "Correctness"
Keeping a development macOS machine up-to-date, which accompanies respective Xcode updates, my intention was to suppress the related error for the No-Mobile-Solution ... as a quick win.
I suppose we could "expand" this to the MAUI-including Solution (and Filtered Solutions respectively) as well, as long as we make sure that ValidateXcodeVersion=false is only set for local development, but definitely not for CI builds.
What do you think?
There was a problem hiding this comment.
I think for the non-mobile slnf files, this makes sense. SDK users could be wanting to make contributions related to ASP.NET Core, without having to install Xcode etc.
We definitely want this check for the mobile filters though... and we just have to use something like xcodes to manage versions locally.
Summary
Use property
<ValidateXcodeVersion>false</ValidateXcodeVersion>for theNO_MOBILESolution.Remarks
When e.g. building on a macOS with Xcode 26.3 installed, the build produces error:
The current macOS/iOS version of .NET is built for Xcode 26.2, but has an identical SDK for Xcode 26.3.
See https://github.com/dotnet/macios/releases/tag/dotnet-10.0.1xx-xcode26.2-10217.
I believe that it is safe to suppress this error for local non-mobile development.