Skip to content

chore: Suppress Xcode version validation for No-Mobile Solution#5054

Merged
jamescrosswell merged 1 commit intomainfrom
chore/suppress-xcode-validation
Mar 30, 2026
Merged

chore: Suppress Xcode version validation for No-Mobile Solution#5054
jamescrosswell merged 1 commit intomainfrom
chore/suppress-xcode-validation

Conversation

@Flash0ver
Copy link
Copy Markdown
Member

Summary

Use property <ValidateXcodeVersion>false</ValidateXcodeVersion> for the NO_MOBILE Solution.

Remarks

When e.g. building on a macOS with Xcode 26.3 installed, the build produces error:

> Xamarin.Shared.Sdk.targets(2370,3): Error  : This version of .NET for macOS (26.2.10191) requires Xcode 26.2. The current version of Xcode is 26.3. Either install Xcode 26.2, or use a different version of .NET for macOS. See https://aka.ms/xcode-requirement for more information.

The current macOS/iOS version of .NET is built for Xcode 26.2, but has an identical SDK for Xcode 26.3.
See https://github.com/dotnet/macios/releases/tag/dotnet-10.0.1xx-xcode26.2-10217.

I believe that it is safe to suppress this error for local non-mobile development.

@Flash0ver Flash0ver self-assigned this Mar 23, 2026
@Flash0ver Flash0ver added the skip-changelog Suppress automatic changelog generation via Craft label Mar 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 23, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.02%. Comparing base (5b676c4) to head (cdd79c5).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5054      +/-   ##
==========================================
+ Coverage   74.00%   74.02%   +0.02%     
==========================================
  Files         499      499              
  Lines       18048    18048              
  Branches     3512     3512              
==========================================
+ Hits        13356    13360       +4     
+ Misses       3838     3831       -7     
- Partials      854      857       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Flash0ver Flash0ver marked this pull request as ready for review March 30, 2026 19:42
Comment thread Directory.Build.props

<PropertyGroup Condition="'$(SolutionName)' == '.generated.NoMobile'">
<NO_MOBILE>true</NO_MOBILE>
<ValidateXcodeVersion>false</ValidateXcodeVersion>
Copy link
Copy Markdown
Member Author

@Flash0ver Flash0ver Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: "Correctness"

Keeping a development macOS machine up-to-date, which accompanies respective Xcode updates, my intention was to suppress the related error for the No-Mobile-Solution ... as a quick win.

I suppose we could "expand" this to the MAUI-including Solution (and Filtered Solutions respectively) as well, as long as we make sure that ValidateXcodeVersion=false is only set for local development, but definitely not for CI builds.

What do you think?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the non-mobile slnf files, this makes sense. SDK users could be wanting to make contributions related to ASP.NET Core, without having to install Xcode etc.

We definitely want this check for the mobile filters though... and we just have to use something like xcodes to manage versions locally.

@jamescrosswell jamescrosswell merged commit e01974e into main Mar 30, 2026
64 of 65 checks passed
@jamescrosswell jamescrosswell deleted the chore/suppress-xcode-validation branch March 30, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Suppress automatic changelog generation via Craft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants