-
-
Notifications
You must be signed in to change notification settings - Fork 230
build(deps): bump gradle/actions from 5.0.2 to 6.1.0 #5130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,7 +130,9 @@ jobs: | |
| path: bin | ||
|
|
||
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5.0.2 | ||
| uses: gradle/actions/setup-gradle@50e97c2cd7a37755bbfafc9c5b7cafaece252f6e # v6.1.0 | ||
| with: | ||
| cache-provider: basic # 'enhanced' (default) is not open source under a proprietary license; 'basic' uses MIT | ||
|
Comment on lines
+134
to
+135
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note: https://github.com/gradle/actions/blob/main/DISTRIBUTION.md Gradle's Setup action changed the licensing of it's caching component ( |
||
|
|
||
| # Cached AVD setup per https://github.com/ReactiveCircus/android-emulator-runner/blob/main/README.md | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: upgrade to
v6.1.0withbasiccaching -or- remain atv5.0.2(for now)The
basiccaching component has significant limitations:But I don't think we need any of these features ... do we?
The
Gradle Technologies Terms of Use(to usev6's Enhanced Caching) are currently under review by Legal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the "Basic Cache Provider" suffices (instead of the "Enhanced Cache Provider"),
we can then also remove the change from #5086 again, which does not work as expected anyway:
sentry-dotnet/.github/dependabot.yml
Lines 25 to 27 in e6a6c24