Conversation
Lms24
reviewed
Aug 11, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
@timfish heads-up: We have to ship an important fix in browser SDKs with v10.4.0 which I think would be great to get into the electron v10 bump right from the start.
I think on the renderer side, we're covered, given my fix applies to BrowserClient. But we should also adjust the behaviour in the main process where we call the now deprecated addAutoIpAddressToUser function. Not sure if adjustment is required elsewhere.
timfish
changed the title
Lms24
approved these changes
Sep 3, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Sorry for the late review! LGTM, thanks for making the IP changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.