chore: remove @rollup/plugin-node-resolve, use npm-run-all2#1215
Merged
timfish merged 2 commits intogetsentry:masterfrom Aug 15, 2025
Merged
chore: remove @rollup/plugin-node-resolve, use npm-run-all2#1215timfish merged 2 commits intogetsentry:masterfrom
timfish merged 2 commits intogetsentry:masterfrom
Conversation
npm-run-all is no longer maintained and can be vulnerable, npm-run-all2 is a maintained drop-in replacement
Contributor
Author
|
rollup/plugin-node-resolve should have no effect until declared and npm-run-all definitely shouldn't make the marks go red. Fails should be unrelated to the changes, but I may be wrong |
Collaborator
|
We've got some flakey tests on Ubuntu most likely caused by it running out of resources. |
timfish
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm-run-allis no longer maintained and can be vulnerable,npm-run-all2is a maintained drop-in replacement (fork).regarding
rollup/plugin-node-resolve. I was running this to investigate:git log --all -p -S "@rollup/plugin-node-resolve"The plugin was added in #756 but was never actually used in
rollup.config.mjs.