fix: preserve electron net request arguments#1393
Merged
timfish merged 1 commit intoJun 30, 2026
Merged
Conversation
timfish
approved these changes
Jun 30, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Electron net integration wrapped
net.requestbut only forwarded the first argument to the original request method. This made the wrapper non-transparent for callers which use Node-compatible request signatures such asrequest(options, callback), causing the callback argument to be dropped.Such as vscode
This updates the wrapper to preserve and forward any additional request arguments while still parsing the first argument for Sentry instrumentation.
Testing
./node_modules/.bin/oxfmt --check src/main/integrations/net-breadcrumbs.ts test/unit/net-trace-propagation.test.tsOXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true ./node_modules/.bin/oxlint src/main/integrations/net-breadcrumbs.ts test/unit/net-trace-propagation.test.ts./node_modules/.bin/vitest run --root=./test/unit net-trace-propagation.test.tsnode scripts/update-version.js && ./node_modules/.bin/vitest run --root=./test/unit