Skip to content

Commit 586d871

Browse files
solnicwhatyouhide
andauthored
Apply suggestions from code review
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
1 parent 0863797 commit 586d871

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

lib/sentry/config.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ defmodule Sentry.Config do
7979
"""
8080
],
8181
skip_error_report_callback: [
82-
type: {:custom, __MODULE__, :__validate_skip_error_report_callback__, []},
82+
type: {:or, [nil, {:fun, 2}]},
8383
default: nil,
8484
type_doc: "`(Oban.Worker.t() | nil, Oban.Job.t() -> boolean())` or `nil`",
8585
doc: """

lib/sentry/integrations/oban/error_reporter.ex

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,12 @@ defmodule Sentry.Integrations.Oban.ErrorReporter do
6767
rescue
6868
error ->
6969
Logger.warning(
70-
"skip_error_report_callback failed for worker #{inspect(worker)} " <>
71-
"(job ID #{job.id}): #{inspect(error)}"
70+
"""
71+
:skip_error_report_callback failed for worker #{inspect(worker)} \
72+
(job ID #{job.id}):
73+
74+
#{Exception.format(:error, error, __STACKTRACE__)}\
75+
"""
7276
)
7377

7478
false

0 commit comments

Comments
 (0)