Skip to content

Commit 8e02968

Browse files
committed
chore: clean up span processor test a bit
1 parent 19d0e04 commit 8e02968

1 file changed

Lines changed: 3 additions & 10 deletions

File tree

test/sentry/opentelemetry/span_processor_test.exs

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ defmodule Sentry.Opentelemetry.SpanProcessorTest do
44
require OpenTelemetry.Tracer, as: Tracer
55
require OpenTelemetry.SemConv.Incubating.HTTPAttributes, as: HTTPAttributes
66
require OpenTelemetry.SemConv.Incubating.URLAttributes, as: URLAttributes
7+
require OpenTelemetry.SemConv.Incubating.DBAttributes, as: DBAttributes
8+
require OpenTelemetry.SemConv.ClientAttributes, as: ClientAttributes
9+
require OpenTelemetry.SemConv.Incubating.MessagingAttributes, as: MessagingAttributes
710

811
import Sentry.TestHelpers
912

@@ -522,8 +525,6 @@ defmodule Sentry.Opentelemetry.SpanProcessorTest do
522525

523526
Sentry.Test.start_collecting_sentry_reports()
524527

525-
require OpenTelemetry.SemConv.ClientAttributes, as: ClientAttributes
526-
527528
Tracer.with_span "POST /api/login", %{
528529
kind: :server,
529530
attributes: %{
@@ -547,8 +548,6 @@ defmodule Sentry.Opentelemetry.SpanProcessorTest do
547548

548549
Sentry.Test.start_collecting_sentry_reports()
549550

550-
require OpenTelemetry.SemConv.Incubating.DBAttributes, as: DBAttributes
551-
552551
Tracer.with_span "SELECT users", %{
553552
kind: :client,
554553
attributes: %{
@@ -571,8 +570,6 @@ defmodule Sentry.Opentelemetry.SpanProcessorTest do
571570

572571
Sentry.Test.start_collecting_sentry_reports()
573572

574-
require OpenTelemetry.SemConv.Incubating.DBAttributes, as: DBAttributes
575-
576573
Tracer.with_span "db.connect", %{
577574
kind: :client,
578575
attributes: %{
@@ -594,8 +591,6 @@ defmodule Sentry.Opentelemetry.SpanProcessorTest do
594591

595592
Sentry.Test.start_collecting_sentry_reports()
596593

597-
require OpenTelemetry.SemConv.Incubating.MessagingAttributes, as: MessagingAttributes
598-
599594
Tracer.with_span "MyApp.Workers.EmailWorker process", %{
600595
kind: :consumer,
601596
attributes: %{
@@ -663,8 +658,6 @@ defmodule Sentry.Opentelemetry.SpanProcessorTest do
663658

664659
Sentry.Test.start_collecting_sentry_reports()
665660

666-
require OpenTelemetry.SemConv.Incubating.DBAttributes, as: DBAttributes
667-
668661
Tracer.with_span "parent_operation" do
669662
Tracer.with_span "db.query", %{
670663
kind: :client,

0 commit comments

Comments
 (0)