Support after_send_event option in send_transaction

Author: solnic

lib/sentry/client.ex

@@ -100,8 +100,7 @@ defmodule Sentry.Client do
     client = Config.client()
 
     # This is a "private" option, only really used in testing.
-    request_retries =
-      Application.get_env(:sentry, :request_retries, Transport.default_retries())
+    request_retries = Application.get_env(:sentry, :request_retries, Transport.default_retries())
 
     client_report
     |> Envelope.from_client_report()
@@ -115,6 +114,7 @@ defmodule Sentry.Client do
     client = Keyword.get_lazy(opts, :client, &Config.client/0)
     sample_rate = Keyword.get_lazy(opts, :sample_rate, &Config.sample_rate/0)
     before_send = Keyword.get_lazy(opts, :before_send, &Config.before_send/0)
+    after_send_event = Keyword.get_lazy(opts, :after_send_event, &Config.after_send_event/0)
 
     request_retries =
       Keyword.get_lazy(opts, :request_retries, fn ->
@@ -123,13 +123,9 @@ defmodule Sentry.Client do
 
     with :ok <- sample_event(sample_rate),
          {:ok, %Transaction{} = transaction} <- maybe_call_before_send(transaction, before_send) do
-      case encode_and_send(transaction, result_type, client, request_retries) do
-        {:ok, id} ->
-          {:ok, id}
-
-        {:error, %ClientError{} = error} ->
-          {:error, error}
-      end
+      send_result = encode_and_send(transaction, result_type, client, request_retries)
+      _ignored = maybe_call_after_send(transaction, send_result, after_send_event)
+      send_result
     else
       :unsampled ->
         ClientReport.Sender.record_discarded_events(:sample_rate, [transaction])
@@ -194,7 +190,7 @@ defmodule Sentry.Client do
     """
   end
 
-  defp maybe_call_after_send(%Event{} = event, result, callback) do
+  defp maybe_call_after_send(event, result, callback) do
     message = ":after_send_event must be an anonymous function or a {module, function} tuple"
 
     case callback do

test/sentry_test.exs

@@ -329,5 +329,23 @@ defmodule SentryTest do
                  end
                )
     end
+
+    test "supports after_send_event option", %{bypass: bypass, transaction: transaction} do
+      parent = self()
+
+      Bypass.expect_once(bypass, "POST", "/api/1/envelope/", fn conn ->
+        Plug.Conn.send_resp(conn, 200, ~s<{"id": "340"}>)
+      end)
+
+      assert {:ok, "340"} =
+               Sentry.send_transaction(
+                 transaction,
+                 after_send_event: fn transaction, {:ok, id} ->
+                   send(parent, {:after_send, transaction.transaction, id})
+                 end
+               )
+
+      assert_receive {:after_send, "test-transaction", "340"}
+    end
   end
 end