Skip to content

chore: Allow usage of hackney 4.x#1054

Merged
solnic merged 2 commits into
getsentry:masterfrom
sax:allow-hackney-4
Jun 11, 2026
Merged

chore: Allow usage of hackney 4.x#1054
solnic merged 2 commits into
getsentry:masterfrom
sax:allow-hackney-4

Conversation

@sax

@sax sax commented May 12, 2026

Copy link
Copy Markdown
Contributor

Description

Hackney has update several major versions in 2026, including security fixes. Looking at the hackney adapter, none of their breaking changes effect the sentry code.

Comment thread mix.exs

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cd763d0. Configure here.

Comment thread lib/mix/tasks/sentry.install.ex Outdated
@sax sax force-pushed the allow-hackney-4 branch from cd763d0 to 9e50faa Compare May 12, 2026 19:26
@sax

sax commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Hmm the CI failure seems to be a setup issue with actions/create-github-app-token.

@sax

sax commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

Ok, looks like there is a transitive dependency conflict. :hackney 4.0.0 split out its HTTP/2 and HTTP3 stacks to an erlang_h2 library. Meanwhile, :opentelemetry_exporter depends on :grpcbox, which depends on :chatterbox... which implements a set of conflicting modules including :h2_connection. joedevivo/chatterbox#154

So technically the Sentry.HackneyClient is fine, but in practice one still can't update hackney to 4.0 until other libraries sort out the conflicts.

@grzuy

grzuy commented May 25, 2026

Copy link
Copy Markdown

For what is worth, note that about 10 hackney CVEs were made public today (https://github.com/benoitc/hackney/security) and 4.x seems to be the only supported version for security updates.

@solnic solnic merged commit aaf9f40 into getsentry:master Jun 11, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants