Skip to content

Commit 0153ab5

Browse files
committed
Fix test
1 parent 7418781 commit 0153ab5

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

sentry-android-core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -675,4 +675,9 @@ public NetworkCallback getNetworkCallback() {
675675
public Thread getInitThread() {
676676
return initThread;
677677
}
678+
679+
@TestOnly
680+
public static void setConnectivityManager(final @Nullable ConnectivityManager cm) {
681+
connectivityManager = cm;
682+
}
678683
}

sentry-android-core/src/test/java/io/sentry/android/core/NetworkBreadcrumbsIntegrationTest.kt

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,12 @@ import io.sentry.SentryNanotimeDate
1616
import io.sentry.TypeCheckHint
1717
import io.sentry.android.core.NetworkBreadcrumbsIntegration.NetworkBreadcrumbConnectionDetail
1818
import io.sentry.android.core.NetworkBreadcrumbsIntegration.NetworkBreadcrumbsNetworkCallback
19+
import io.sentry.android.core.internal.util.AndroidConnectionStatusProvider
1920
import io.sentry.test.DeferredExecutorService
2021
import io.sentry.test.ImmediateExecutorService
2122
import java.util.concurrent.TimeUnit
23+
import kotlin.test.AfterTest
24+
import kotlin.test.BeforeTest
2225
import kotlin.test.Test
2326
import kotlin.test.assertEquals
2427
import kotlin.test.assertFalse
@@ -47,12 +50,6 @@ class NetworkBreadcrumbsIntegrationTest {
4750
var nowMs: Long = 0
4851
val network = mock<Network>()
4952

50-
init {
51-
whenever(mockBuildInfoProvider.sdkInfoVersion).thenReturn(Build.VERSION_CODES.N)
52-
whenever(context.getSystemService(eq(Context.CONNECTIVITY_SERVICE)))
53-
.thenReturn(connectivityManager)
54-
}
55-
5653
fun getSut(
5754
enableNetworkEventBreadcrumbs: Boolean = true,
5855
buildInfo: BuildInfoProvider = mockBuildInfoProvider,
@@ -73,6 +70,18 @@ class NetworkBreadcrumbsIntegrationTest {
7370

7471
private val fixture = Fixture()
7572

73+
@BeforeTest
74+
fun `set up`() {
75+
whenever(fixture.mockBuildInfoProvider.sdkInfoVersion).thenReturn(Build.VERSION_CODES.N)
76+
whenever(fixture.context.getSystemService(eq(Context.CONNECTIVITY_SERVICE)))
77+
.thenReturn(fixture.connectivityManager)
78+
}
79+
80+
@AfterTest
81+
fun `tear down`() {
82+
AndroidConnectionStatusProvider.setConnectivityManager(null)
83+
}
84+
7685
@Test
7786
fun `When network events breadcrumb is enabled, it registers callback`() {
7887
val sut = fixture.getSut()

0 commit comments

Comments
 (0)