Use lock for capturer insantiation, removeCallbacks of capturer before scheduling new ones

Author: romtsn

sentry-android-replay/src/main/java/io/sentry/android/replay/WindowRecorder.kt

@@ -33,6 +33,7 @@ internal class WindowRecorder(
   private val rootViews = ArrayList<WeakReference<View>>()
   private var lastKnownWindowSize: Point = Point()
   private val rootViewsLock = AutoClosableReentrantLock()
+  private val capturerLock = AutoClosableReentrantLock()
   @Volatile private var capturer: Capturer? = null
 
   private class Capturer(
@@ -50,6 +51,8 @@ internal class WindowRecorder(
       }
       recorder?.resume()
       isRecording.getAndSet(true)
+      // Remove any existing callbacks to prevent concurrent capture loops
+      mainLooperHandler.removeCallbacks(this)
       val posted = mainLooperHandler.post(this)
       if (!posted) {
         options.logger.log(
@@ -165,8 +168,12 @@ internal class WindowRecorder(
     }
 
     if (capturer == null) {
-      // don't recreate runnable for every config change, just update the config
-      capturer = Capturer(options, mainLooperHandler)
+      capturerLock.acquire().use {
+        if (capturer == null) {
+          // don't recreate runnable for every config change, just update the config
+          capturer = Capturer(options, mainLooperHandler)
+        }
+      }
     }
 
     capturer?.config = config
@@ -184,6 +191,9 @@ internal class WindowRecorder(
       capturer?.recorder?.bind(newRoot)
     }
 
+    // Remove any existing callbacks to prevent concurrent capture loops
+    mainLooperHandler.removeCallbacks(capturer)
+
     val posted =
       mainLooperHandler.postDelayed(
         capturer,
@@ -215,7 +225,7 @@ internal class WindowRecorder(
 
   override fun stop() {
     capturer?.stop()
-    capturer = null
+    capturerLock.acquire().use { capturer = null }
     isRecording.set(false)
   }