Skip to content

Commit 23b2680

Browse files
markushigetsentry-botclaude
authored
fix(replay): text layouts with center/end alignment return incorrect masking bounding box (#5218)
* Remove fill workaround, shortcut calculations if there's only one line of text * changelog * Revert "Remove fill workaround, shortcut calculations if there's only one line of text" This reverts commit cfdcadc. * Work around erroneous paragraph return values * Cover some more edge cases * Format code * Trigger Build * fix dependencies * Add snapshot tests for non-ellipsized multi-line text masking Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent ae6907d commit 23b2680

17 files changed

+460
-73
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### Fixes
6+
7+
- Session Replay: Fix Compose text masking mismatch with weighted text ([#5218](https://github.com/getsentry/sentry-java/pull/5218))
8+
59
### Features
610

711
- Add configurable `IScopesStorageFactory` to `SentryOptions` for providing a custom `IScopesStorage`, e.g. when the default `ThreadLocal`-backed storage is incompatible with non-pinning thread models ([#5199](https://github.com/getsentry/sentry-java/pull/5199))

sentry-android-core/build.gradle.kts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import org.jetbrains.kotlin.config.KotlinCompilerVersion
44
plugins {
55
id("com.android.library")
66
alias(libs.plugins.kotlin.android)
7+
alias(libs.plugins.kotlin.compose)
78
jacoco
89
alias(libs.plugins.jacoco.android)
910
alias(libs.plugins.errorprone)
@@ -108,7 +109,11 @@ dependencies {
108109
testImplementation(projects.sentryCompose)
109110
testImplementation(projects.sentryAndroidNdk)
110111
testImplementation(libs.dropbox.differ)
111-
testRuntimeOnly(libs.androidx.compose.ui)
112+
testImplementation(libs.androidx.activity.compose)
113+
testImplementation(libs.androidx.compose.ui)
114+
testImplementation(libs.androidx.compose.foundation)
115+
testImplementation(libs.androidx.compose.foundation.layout)
116+
testImplementation(libs.androidx.compose.material3)
112117
testRuntimeOnly(libs.androidx.fragment.ktx)
113118
testRuntimeOnly(libs.timber)
114119
}

0 commit comments

Comments
 (0)