Rate limit for log items

Author: adinauer

sentry/src/main/java/io/sentry/DataCategory.java

@@ -10,6 +10,7 @@ public enum DataCategory {
   Error("error"),
   Session("session"),
   Attachment("attachment"),
+  LogItem("log_item"),
   Monitor("monitor"),
   Profile("profile"),
   ProfileChunkUi("profile_chunk_ui"),

sentry/src/main/java/io/sentry/clientreport/ClientReportRecorder.java

@@ -177,6 +177,9 @@ private DataCategory categoryFromItemType(SentryItemType itemType) {
     if (SentryItemType.ReplayVideo.equals(itemType)) {
       return DataCategory.Replay;
     }
+    if (SentryItemType.Log.equals(itemType)) {
+      return DataCategory.LogItem;
+    }
 
     return DataCategory.Default;
   }

sentry/src/main/java/io/sentry/transport/RateLimiter.java

@@ -202,6 +202,8 @@ private boolean isRetryAfter(final @NotNull String itemType) {
         return DataCategory.Monitor;
       case "replay_video":
         return DataCategory.Replay;
+      case "log":
+        return DataCategory.LogItem;
       default:
         return DataCategory.Unknown;
     }

sentry/src/test/java/io/sentry/transport/RateLimiterTest.kt

@@ -16,6 +16,9 @@ import io.sentry.SentryEnvelope
 import io.sentry.SentryEnvelopeHeader
 import io.sentry.SentryEnvelopeItem
 import io.sentry.SentryEvent
+import io.sentry.SentryLogEvent
+import io.sentry.SentryLogEvents
+import io.sentry.SentryLongDate
 import io.sentry.SentryOptions
 import io.sentry.SentryOptionsManipulator
 import io.sentry.SentryReplayEvent
@@ -336,6 +339,26 @@ class RateLimiterTest {
         verifyNoMoreInteractions(fixture.clientReportRecorder)
     }
 
+    @Test
+    fun `drop log items as lost`() {
+        val rateLimiter = fixture.getSUT()
+        val scopes = mock<IScopes>()
+        whenever(scopes.options).thenReturn(SentryOptions())
+
+        val logEventItem = SentryEnvelopeItem.fromLogs(fixture.serializer, SentryLogEvents(listOf(
+            SentryLogEvent(SentryId(), SentryLongDate(0), "hello")
+        )))
+        val envelope = SentryEnvelope(SentryEnvelopeHeader(null), arrayListOf(logEventItem))
+
+        rateLimiter.updateRetryAfterLimits("60:log_item:key", null, 1)
+        val result = rateLimiter.filter(envelope, Hint())
+
+        assertNull(result)
+
+        verify(fixture.clientReportRecorder, times(1)).recordLostEnvelopeItem(eq(DiscardReason.RATELIMIT_BACKOFF), same(logEventItem))
+        verifyNoMoreInteractions(fixture.clientReportRecorder)
+    }
+
     @Test
     fun `drop profileChunk items as lost`() {
         val rateLimiter = fixture.getSUT()