perf(breadcrumbs): Make SystemEventsBreadcrumbsIntegration faster (#4330)

* Make SystemEventsBreadcrumbsIntegration faster

* Changelog

* Fix leak

Author: romtsn

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - Compress Screenshots on a background thread ([#4295](https://github.com/getsentry/sentry-java/pull/4295))
 - Improve low memory breadcrumb capturing ([#4325](https://github.com/getsentry/sentry-java/pull/4325))
+- Make `SystemEventsBreadcrumbsIntegration` faster ([#4330](https://github.com/getsentry/sentry-java/pull/4330))
 
 ## 7.22.5
 

sentry-android-core/src/main/java/io/sentry/android/core/SystemEventsBreadcrumbsIntegration.java

@@ -37,7 +37,7 @@
 import io.sentry.util.StringUtils;
 import java.io.Closeable;
 import java.io.IOException;
-import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -53,19 +53,25 @@ public final class SystemEventsBreadcrumbsIntegration implements Integration, Cl
 
   private @Nullable SentryAndroidOptions options;
 
-  private final @NotNull List<String> actions;
+  private final @NotNull String[] actions;
   private boolean isClosed = false;
   private final @NotNull Object startLock = new Object();
 
   public SystemEventsBreadcrumbsIntegration(final @NotNull Context context) {
-    this(context, getDefaultActions());
+    this(context, getDefaultActionsInternal());
+  }
+
+  private SystemEventsBreadcrumbsIntegration(
+      final @NotNull Context context, final @NotNull String[] actions) {
+    this.context = ContextUtils.getApplicationContext(context);
+    this.actions = actions;
   }
 
   public SystemEventsBreadcrumbsIntegration(
       final @NotNull Context context, final @NotNull List<String> actions) {
-    this.context =
-        Objects.requireNonNull(ContextUtils.getApplicationContext(context), "Context is required");
-    this.actions = Objects.requireNonNull(actions, "Actions list is required");
+    this.context = ContextUtils.getApplicationContext(context);
+    this.actions = new String[actions.size()];
+    actions.toArray(this.actions);
   }
 
   @Override
@@ -127,28 +133,32 @@ private void startSystemEventsReceiver(
     }
   }
 
-  @SuppressWarnings("deprecation")
   public static @NotNull List<String> getDefaultActions() {
-    final List<String> actions = new ArrayList<>();
-    actions.add(ACTION_SHUTDOWN);
-    actions.add(ACTION_AIRPLANE_MODE_CHANGED);
-    actions.add(ACTION_BATTERY_CHANGED);
-    actions.add(ACTION_CAMERA_BUTTON);
-    actions.add(ACTION_CONFIGURATION_CHANGED);
-    actions.add(ACTION_DATE_CHANGED);
-    actions.add(ACTION_DEVICE_STORAGE_LOW);
-    actions.add(ACTION_DEVICE_STORAGE_OK);
-    actions.add(ACTION_DOCK_EVENT);
-    actions.add(ACTION_DREAMING_STARTED);
-    actions.add(ACTION_DREAMING_STOPPED);
-    actions.add(ACTION_INPUT_METHOD_CHANGED);
-    actions.add(ACTION_LOCALE_CHANGED);
-    actions.add(ACTION_SCREEN_OFF);
-    actions.add(ACTION_SCREEN_ON);
-    actions.add(ACTION_TIMEZONE_CHANGED);
-    actions.add(ACTION_TIME_CHANGED);
-    actions.add("android.os.action.DEVICE_IDLE_MODE_CHANGED");
-    actions.add("android.os.action.POWER_SAVE_MODE_CHANGED");
+    return Arrays.asList(getDefaultActionsInternal());
+  }
+
+  @SuppressWarnings("deprecation")
+  private static @NotNull String[] getDefaultActionsInternal() {
+    final String[] actions = new String[19];
+    actions[0] = ACTION_SHUTDOWN;
+    actions[1] = ACTION_AIRPLANE_MODE_CHANGED;
+    actions[2] = ACTION_BATTERY_CHANGED;
+    actions[3] = ACTION_CAMERA_BUTTON;
+    actions[4] = ACTION_CONFIGURATION_CHANGED;
+    actions[5] = ACTION_DATE_CHANGED;
+    actions[6] = ACTION_DEVICE_STORAGE_LOW;
+    actions[7] = ACTION_DEVICE_STORAGE_OK;
+    actions[8] = ACTION_DOCK_EVENT;
+    actions[9] = ACTION_DREAMING_STARTED;
+    actions[10] = ACTION_DREAMING_STOPPED;
+    actions[11] = ACTION_INPUT_METHOD_CHANGED;
+    actions[12] = ACTION_LOCALE_CHANGED;
+    actions[13] = ACTION_SCREEN_OFF;
+    actions[14] = ACTION_SCREEN_ON;
+    actions[15] = ACTION_TIMEZONE_CHANGED;
+    actions[16] = ACTION_TIME_CHANGED;
+    actions[17] = "android.os.action.DEVICE_IDLE_MODE_CHANGED";
+    actions[18] = "android.os.action.POWER_SAVE_MODE_CHANGED";
     return actions;
   }
 
@@ -204,10 +214,43 @@ public void onReceive(final Context context, final @NotNull Intent intent) {
                   hub.addBreadcrumb(breadcrumb, hint);
                 });
       } catch (Throwable t) {
-        options
-            .getLogger()
-            .log(SentryLevel.ERROR, t, "Failed to submit system event breadcrumb action.");
+        // ignored
+      }
+    }
+
+    // in theory this should be ThreadLocal, but we won't have more than 1 thread accessing it,
+    // so we save some memory here and CPU cycles. 64 is because all intent actions we subscribe for
+    // are less than 64 chars. We also don't care about encoding as those are always UTF.
+    // TODO: _MULTI_THREADED_EXECUTOR_
+    private final char[] buf = new char[64];
+
+    @TestOnly
+    @Nullable
+    String getStringAfterDotFast(final @Nullable String str) {
+      if (str == null) {
+        return null;
       }
+
+      final int len = str.length();
+      int bufIndex = buf.length;
+
+      // the idea here is to iterate from the end of the string and copy the characters to a
+      // pre-allocated buffer in reverse order. When we find a dot, we create a new string
+      // from the buffer. This way we use a fixed size buffer and do a bare minimum of iterations.
+      for (int i = len - 1; i >= 0; i--) {
+        final char c = str.charAt(i);
+        if (c == '.') {
+          return new String(buf, bufIndex, buf.length - bufIndex);
+        }
+        if (bufIndex == 0) {
+          // Overflow — fallback to safe version
+          return StringUtils.getStringAfterDot(str);
+        }
+        buf[--bufIndex] = c;
+      }
+
+      // No dot found — return original
+      return str;
     }
 
     private @NotNull Breadcrumb createBreadcrumb(
@@ -218,7 +261,7 @@ public void onReceive(final Context context, final @NotNull Intent intent) {
       final Breadcrumb breadcrumb = new Breadcrumb(timeMs);
       breadcrumb.setType("system");
       breadcrumb.setCategory("device.event");
-      final String shortAction = StringUtils.getStringAfterDot(action);
+      final String shortAction = getStringAfterDotFast(action);
       if (shortAction != null) {
         breadcrumb.setData("action", shortAction);
       }

sentry-android-core/src/test/java/io/sentry/android/core/SystemEventsBreadcrumbsIntegrationTest.kt

@@ -102,6 +102,8 @@ class SystemEventsBreadcrumbsIntegrationTest {
         sut.register(fixture.hub, fixture.options)
         val intent = Intent().apply {
             action = Intent.ACTION_TIME_CHANGED
+            putExtra("test", 10)
+            putExtra("test2", 20)
         }
         sut.receiver!!.onReceive(fixture.context, intent)
 
@@ -180,4 +182,50 @@ class SystemEventsBreadcrumbsIntegrationTest {
 
         assertFalse(fixture.options.isEnableSystemEventBreadcrumbs)
     }
+
+    @Test
+    fun `when str has full package, return last string after dot`() {
+        val sut = fixture.getSut()
+
+        sut.register(fixture.scopes, fixture.options)
+
+        assertEquals("DEVICE_IDLE_MODE_CHANGED", sut.receiver?.getStringAfterDotFast("io.sentry.DEVICE_IDLE_MODE_CHANGED"))
+        assertEquals("POWER_SAVE_MODE_CHANGED", sut.receiver?.getStringAfterDotFast("io.sentry.POWER_SAVE_MODE_CHANGED"))
+    }
+
+    @Test
+    fun `when str is null, return null`() {
+        val sut = fixture.getSut()
+
+        sut.register(fixture.scopes, fixture.options)
+
+        assertNull(sut.receiver?.getStringAfterDotFast(null))
+    }
+
+    @Test
+    fun `when str is empty, return the original str`() {
+        val sut = fixture.getSut()
+
+        sut.register(fixture.scopes, fixture.options)
+
+        assertEquals("", sut.receiver?.getStringAfterDotFast(""))
+    }
+
+    @Test
+    fun `when str ends with a dot, return empty str`() {
+        val sut = fixture.getSut()
+
+        sut.register(fixture.scopes, fixture.options)
+
+        assertEquals("", sut.receiver?.getStringAfterDotFast("io.sentry."))
+    }
+
+    @Test
+    fun `when str has no dots, return the original str`() {
+        val sut = fixture.getSut()
+
+        sut.register(fixture.scopes, fixture.options)
+
+        assertEquals("iosentry", sut.receiver?.getStringAfterDotFast("iosentry"))
+    }
 }